[jsword-devel] [JIRA] Commented: (JS-187) JSword error when showing WEB/HNV text

[DM Smith (JIRA)]

    [ http://www.crosswire.org/bugs/browse/JS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14871#comment-14871 ] 

DM Smith commented on JS-187:
-----------------------------

The content of the verse is not well-formed. For that reason all the tags are stripped out of it and it is displayed as is.

Here is the content:
After the suffering of his soul,</l> <l type="x-secondary">he will see the <milestone type="x-noteStartAnchor"/>light<note type="translation">So read the Dead Sea Scrolls and Septuagint. Masoretic Text omits “the light”.</note> and be satisfied.</l> </lg> <lg> <l type="x-primary">My righteous servant will justify many by the knowledge of himself;</l> <l type="x-secondary">and he will bear their iniquities.</l> </lg> <lg> <l type="x-primary">

I think this is a bug in the module, not in JSword. Although, JSword could do a better job of handling badly formed xml.

Two elements are badly formed. The first is a bit into the verse with an ending </l>. Then the verse ends with the start of an element <l type="x-primary">. It appears to me that the <l type="x-primary"> should be at the beginning of the verse, not at the end. (My guess is that the <verse> start was inside the <l type="x-primary">, so that the number was to be tight against the text, and that osis2mod split the verses at the wrong point.)

The reason that xiphos shows it well for a few reasons:
# The SWORD engine transforms the text as a stream using a custom parser that does not care if the text is well-formed or not. There are some plusses of this methodology, but it is not handle the full spec of OSIS.
# The whole chapter of transformed text is concatenated together and then displayed.
# The display engine is an HTML browser, which is tolerant of badly formed HTML.
However, xiphos can display the content of a single verse (as in a search hit list) and in that case, the display might be ugly.

I think there is an open issue for JSword to handle badly formed XML better. I've been looking at various solutions. But none quite fit (e.g. one was for xhtml, not xml generally). If I can find it, I'm going to either close this issue as a duplicate otherwise I'll create one or re-characterize this one. I'll also open this as an issue against the module.
 

> JSword error when showing WEB/HNV text
> --------------------------------------
>
>                 Key: JS-187
>                 URL: http://www.crosswire.org/bugs/browse/JS-187
>             Project: JSword
>          Issue Type: Bug
>          Components: o.c.jsword.book.sword
>    Affects Versions: 1.6.1
>         Environment: BibleDesktop (Windows) & And Bible (Android)
>            Reporter: Martin Denham
>            Assignee: DM Smith
>
> WEB/HNV Isaiah 53:11 displays a note in the middle of the bible text (see half way along the next line beginning 'So read..'):
>  11After the suffering of his soul, he will see the lightSo read the Dead Sea Scrolls and Septuagint. Masoretic Text omits "the light". and be satisfied.
> This seems to be a JSword error because Xiphos does not have the problem but BibleDesktop and And Bible do have the problem.
> I don't use WEB/HNV very much so I am not sure how widely spread this problem is.
> Thanks
> Martin

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira