[jsword-devel] [JIRA] Commented: (JS-126) Can we consider increasing the timeout value in WebResource

[DM Smith (JIRA)]

    [ http://www.crosswire.org/bugs/browse/JS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501#action_13501 ] 

DM Smith commented on JS-126:
-----------------------------

Making it adjustable is a great idea. Static would be fine if there are no situations where in a single JVM one would want different timeouts. We have a separate issue open regarding concurrency and class level properties.

> Can we consider increasing the timeout value in WebResource
> -----------------------------------------------------------
>
>                 Key: JS-126
>                 URL: http://www.crosswire.org/bugs/browse/JS-126
>             Project: JSword
>          Issue Type: Improvement
>          Components: o.c.common.util
>         Environment: Android mobile
>            Reporter: Martin Denham
>            Assignee: DM Smith
>            Priority: Minor
>
> Can we consider increasing the timeout value at the bottom of o.c.common.util.WebResource.java?  I am using a timeout of 3 seconds in And Bible and it seems to have helped connection reliability.
> I suspect the timeout was originally 2 seconds because there is a comment half way down the file (which probably needs correcting) that says:
>         // Set a 2 second timeout on getting a connection.
> and then the code sets the timeout to 0.75 sec.
> Mobile phones have very variable connections and some informal tests seemed to show that increasing the timeout to 3 seconds had a beneficial affect.
> Alternatively, another possibility might be to add a static setter:
>    public static void setTimeout(int timeout)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.crosswire.org/bugs/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira