[jsword-devel] Nave's Topical Bible Reference linking

[trent.jsword at trentonadams.ca]

Sorry for the delay in replying, I was busy with the wife and kids all day.  We went bowling and what not, lot's of fun.

Nope, wasn't aware of that new beta, I'll check for that next time I work on changes related to an existing module.

I'll have to fix up my XSL that I gave you previously.  The "otherwise" may need to just be removed, and replaced with something else, like checking for non-existent attributes, depending, as it conflicts with the TEI stuff in the new Nave's.

But, the replace I gave you is almost right, I just have to make it work with multi-line mode.  I'll make the replacement check for version 1.0 as well, and that way the new Nave's in beta will be completely ignored.  Does that sound like a good way of doing this?

Should the code somehow be marked for removal at a later date?  Or should we keep it around for quite awhile after the new Nave's is moved to production?  I'd imagine, so we don't affect users too much, we may just want to leave it, eh?

Anyhow, I'm going to work on some of the XSL, and test a bit.  I'm seeing some issues with the new Nave's, cause it doesn't appear to be marked up properly in some cases, in which case I should probably report it.

Thanks.

----- "DM Smith" <dmsmith at crosswire.org> wrote:

> From: "DM Smith" <dmsmith at crosswire.org>
> To: "Trenton D. Adams" <trent.jsword at trentonadams.ca>, "J-Sword Developers Mailing List" <jsword-devel at crosswire.org>
> Sent: Monday, March 1, 2010 6:39:23 AM GMT -06:00 US/Canada Central
> Subject: Re: [jsword-devel] Nave's Topical Bible Reference linking
>
> I think there's a beta for it.
> Are you using that?
> -- DM
> 
> On Mar 1, 2010, at 2:40 AM, Trenton D. Adams wrote:
> 
> > textPaneBookDataDisplay.refresh()
> > 
> > Under the following line...
> >            String text = XMLUtil.writeToString(htmlsep);
> > 
> > put....
> >            if ("Nave".equals(bmd.getInitials())) {
> >                text = text.replaceAll("(#)(.+\\|)", "$1<a
> href=\"bible://{$2}\">$2</a>");
> >            }
> > 
> > 1. The Nave's is pretty much raw text, and the biblical references
> are not marked up as far as I can see.  So, I figured a regex
> replacement with a link was the best way of doing it.
> > 2. Used the convenience method replaceAll() as it's a single call,
> unless you want to cache a pre-compiled pattern matcher in some way?
> > 
> > Any thoughts?  Can we add this?
> > 
> > Thanks.
> > 
> > _______________________________________________
> > jsword-devel mailing list
> > jsword-devel at crosswire.org
> > http://www.crosswire.org/mailman/listinfo/jsword-devel