[jsword-devel] Updated Indonesian Locale for JSword and BibleDesktop

[DM Smith]

Tonny,
This is the simplest part of the problem. But there's more. I'll  
outline the problem separately. Either here or in the wiki.
DM
On Aug 29, 2008, at 5:09 AM, Tonny Kohar wrote:

> HI,
>
> On Fri, Aug 29, 2008 at 3:24 PM, Tonny Kohar <tonny.kohar at gmail.com>  
> wrote:
>> Hi,
>>
>> On Fri, Aug 29, 2008 at 10:42 AM, Tonny Kohar  
>> <tonny.kohar at gmail.com> wrote:
>>> Hi,
>>>
>>>> The problem with the '-' is a design flaw in both SWORD and  
>>>> JSword. It
>>>> needs to be fixed. It is not all that easy given how the code is
>>>> written. But it is becoming more important.
>>>>
>>>> There is another problem regarding non-English Bible book names.  
>>>> JSword
>>>> does not handle them well on input for a lookup. This too needs  
>>>> to be fixed.
>>>>
>>>> I'll see what I can do about these, but anyone that can take a  
>>>> look at
>>>> it and figure it out would be greatly appreciated.
>>>>
>>>
>>> I will try to look at it and maybe could come out with something, is
>>> there specific package (org.crosswire.xxx) or class implementation
>>> that I need to pay attention to ?
>>
>> I am still looking through org.crosswire.jsword.versification.* and
>> org.crosswire.jsword.passage.*, it seem ok, it deal with number for
>> book, chapter,verse), so it should not be a problem for locale, but I
>> haven't dig deep enough.
>>
>
> I found it, it is in the  
> org.crosswire.jsword.passage.VerseRangeFactory
> public static VerseRange fromString(String original, VerseRange basis)
>
> It is because the delimeter is hardcoded using
> VerseRange.RANGE_ALLOWED_DELIMS which is "-" currently.
> So somehow jsword need to have public API that allow to change the
> final static RANGE_ALLOWED_DELIMS using user preferences/locale
> specific. In there I also found RANGE_PREF_DELIM which seem it is not
> used, maybe this can be used for this purpose.
>
> Cheers
> Tonny Kohar
>
>> Another note:
>> - Is it possible to give the following consistent API especially  
>> for the null.
>> org.crosswire.jsword.passage.KeyUtil
>> *public static Verse getVerse(Key key)
>> this part will return funny things (undefined) if the key is null
>> *public static Passage getPassage(Key key)
>> this part will return null, if the key is null
>> so it is possible for the above to methods to have consistent api ? I
>> think adding null key check for getVerse similar to getPassage in the
>> first line.
>>
>
> -- 
> Citra FX Photo Effects
> imagine, design, create ...
> http://www.kiyut.com
>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel