From joseph.walker at gmail.com Sat Jan 15 05:24:16 2005 From: joseph.walker at gmail.com (Joe Walker) Date: Sat Jan 15 05:24:02 2005 Subject: [jsword-devel] Check-ins Message-ID: <5dd4742605011504243ff38e3c@mail.gmail.com> Hi, I've spent some time trying to fix the jdom bug (although I've not pinned it down yet), and checking in a number of other minor changes, most of which are down to things that intellij picked up which I was testing it a while ago. I've also checked in an updated user manual that Brent sent over. Thanks! Joe. From scribe at crosswire.org Fri Jan 21 17:57:59 2005 From: scribe at crosswire.org (Troy A. Griffitts) Date: Fri Jan 21 17:57:07 2005 Subject: [jsword-devel] Flashgen for Flashcards Message-ID: <41F1A517.40107@crosswire.org> I just commited a new utility to the flashcards repository. It's supposed to be useful for autogenerating flashcard lesson sets. It allows input of a Translation, Scripture range, and number of words per lesson. ./flashgen KJV "eph" 25 It will then analize the text, collate all words and compute freq. Procedes to look up lexical form in NasbGreek, and grabs accented Greek word. Then collates translation choices from base text (KJV in our example), sorts by freq and uses these as the 'back' or 'answer' for the cards. Maybe we can make an online page from the flashcards home that prompts for a range and lesson count, and then autogenerates the lessonset .jar and sends to the user's browser for download? Hope it's useful, -Troy. From dmsmith555 at yahoo.com Mon Jan 24 16:59:53 2005 From: dmsmith555 at yahoo.com (DM Smith) Date: Mon Jan 24 16:59:45 2005 Subject: [jsword-devel] Checkin Message-ID: <41F58BF9.3090309@yahoo.com> Hi, Well it has been a while since I have been able to work on JSword. I have just checked in a bunch of little changes. Mostly adding a serialVersionUID or updating the values to non-default ones. I also fixed a bug that was preventing me from doing downloads. I have been working on making the installer a bit more friendly by categorizing books by language. I started it last August and have just finished. I have tried to make the implementation a bit flexible, but it is more like a leaning toward flexibility. What I wanted was to create a generic way that a user could specify the order of book attributes that they were interested in. That is for a later day. For now, I have "hard coded" a grouping first by book type, then by language and finally by book name. I had to re-write the tree of installed and available books. This implementation uses some new classes: BookNode - (A grouped book that is or may be installed) Filter - A way of filtering objects. SortedListSet - implements List and Set maintaining a sorted order of the objects within it. BookMetaDataSet - A set of books that may be easily be subsetted by grouping and filters. In doing this I found a bug in the installer. I tried to install "Ergane Afrikaans to English Glossary" and it failed. Seems that the module code tries to compute where modules should be installed but uses "DataPath" in the config to get the data. In this case, the two do not agree. Seems like we should use the "DataPath" and not compute it. I'll enter this into the bug tracker. Later, DM From dmsmith555 at yahoo.com Tue Jan 25 21:55:38 2005 From: dmsmith555 at yahoo.com (DM Smith) Date: Tue Jan 25 21:55:27 2005 Subject: [jsword-devel] Lucene search bug Message-ID: <41F722CA.2070807@yahoo.com> I had noted earlier that when I searched on "bread" in the KJV, I only got about 20 hits. I have been looking into what is happening. In doing so I found a bug which at first I thought might have been related. Seems that the call BookData data = book.getData(subkey); String text = data.getPlainText(); returns the verse reference butt up against the verse text, as in: Gen 1.1In the beginning God created the heavens and the earth..... Turns out that the document is something like:
Gen 1.1 In the beginning...
(this is leaving out attributes and other details) It concatenates the text from all the children of the div element. Seems to me that it should only do so for verse text. The code is insensitive as to whether the text is for a title, note, footnote or some other non-verse element. How should it be? (In my copy, I have it skipping the title element.) Anyway, enough with that digression from the indexing problem. I put in a breakpoint on the verse when it contained "bread" and found that the data was in fact getting to the indexer. In looking at the verses, it seemed that they had "bread" in more than once. This made me go down the wrong path of seeing whether it was only indexing words in verses if they occurred multiple times. I then ran a bunch of searches on common words (Lord, God, Jesus, bread, ...) and none of them came back with more than 21 verses. Also, after deleting and regenerating the index (after I removed the leading verse reference), the results were a different 20. I think what is happening is that the search is not returning an exhaustive answer, but is trying to come up with the top 20. From dmsmith555 at yahoo.com Wed Jan 26 19:31:09 2005 From: dmsmith555 at yahoo.com (DM Smith) Date: Wed Jan 26 19:30:53 2005 Subject: [jsword-devel] Lucene searching improved Message-ID: <41F8526D.4010301@yahoo.com> Hi, I have fixed the bug in the search where bread returned 20 results rather than over 350. The problem was that it was using a PassageTally to collect the results. I changed the code to call book.createEmptyKeyList(). This uses the user's choice of Passage. By default it is set to RocketPassage. Is there a better default? I also changed the indexing to save the verse reference as UnIndexed. As it was the verse was being indexed and stored. I didn't see a need to index the verse as it is indexed already. And the search logic never searched against that Field. I also changed BookData to skip the children of the
element that are not elements. The call to getPlainText still gets and indexes the non-verse text in the element. Gen 18.5 in the KJV is an example. In His Service, DM From dmsmith555 at yahoo.com Wed Jan 26 20:27:47 2005 From: dmsmith555 at yahoo.com (DM Smith) Date: Wed Jan 26 20:27:31 2005 Subject: [jsword-devel] Check-ins In-Reply-To: <5dd4742605011504243ff38e3c@mail.gmail.com> References: <5dd4742605011504243ff38e3c@mail.gmail.com> Message-ID: <41F85FB3.5080907@yahoo.com> Joe, I tried to dl the nightly via webstart. I got the same error you found. I examined the jdom.jar file and it is the 1.0 (Sept 9, 2004). This is the same as what is under source code control. The method that cannot be found is in the jar. My guess is that we are running into the Manifest problem that we had with another jar. I think a good test is to run it using those jars that WebStart downloaded directly via a shell script. And another test is to remove Manifest from the jar and see if that works. DM Joe Walker wrote: >Hi, > >I've spent some time trying to fix the jdom bug (although I've not >pinned it down yet), and checking in a number of other minor changes, >most of which are down to things that intellij picked up which I was >testing it a while ago. > >I've also checked in an updated user manual that Brent sent over. Thanks! > >Joe. >_______________________________________________ >jsword-devel mailing list >jsword-devel@crosswire.org >http://www.crosswire.org/mailman/listinfo/jsword-devel > > > > From dmsmith555 at yahoo.com Sat Jan 29 19:28:06 2005 From: dmsmith555 at yahoo.com (DM Smith) Date: Sat Jan 29 19:27:56 2005 Subject: [jsword-devel] Check-ins In-Reply-To: <41F85FB3.5080907@yahoo.com> References: <5dd4742605011504243ff38e3c@mail.gmail.com> <41F85FB3.5080907@yahoo.com> Message-ID: <41FC4636.9080309@yahoo.com> Joe, I took a closer look at the error. I think that the nightly build is corrupted. Here is what I did to test the theory. I clobbered all the artifacts I had in Eclipse and under target/ant for each project (i.e. bibledesktop-ant-clean). I then rebuilt everything. I copied all the jars out of bibledesktop/ant/signed into an empty directory. I also copied jsword.bat and lcp.bat into it. Jsword.bat ran just fine. I then copied the jars one at a time from www.crosswire.org/bibledesktop/nightly over top and ran the program after copying each one. It ran just fine until I copied jsword.jar. I did further tests to see if there were any other combination (local and download) and only jsword.jar failed. I think what happened was that since the jdom.jar pre 1.0 jar was replaced with the 1.0 jar of the same name that the *.class files under jsword project did not rebuild when they should have. (Perhaps we should always have the version number as part of the jar name.) I think that running an ant-clean in jsword will fox the problem. So will renaming the jar and changing the build to use the new jar name. Joe, can you take care of it? I am not sure where to find the files on the server or how to run ant from the command line. I could do the rename under eclipse, if you want me to. Later, DM DM Smith wrote: > Joe, > I tried to dl the nightly via webstart. I got the same error you > found. I examined the jdom.jar file and it is the 1.0 (Sept 9, 2004). > This is the same as what is under source code control. The method that > cannot be found is in the jar. My guess is that we are running into > the Manifest problem that we had with another jar. I think a good test > is to run it using those jars that WebStart downloaded directly via a > shell script. And another test is to remove Manifest from the jar and > see if that works. > DM > > Joe Walker wrote: > >> Hi, >> >> I've spent some time trying to fix the jdom bug (although I've not >> pinned it down yet), and checking in a number of other minor changes, >> most of which are down to things that intellij picked up which I was >> testing it a while ago. >> >> I've also checked in an updated user manual that Brent sent over. >> Thanks! >> >> Joe. >> _______________________________________________ >> jsword-devel mailing list >> jsword-devel@crosswire.org >> http://www.crosswire.org/mailman/listinfo/jsword-devel >> >> >> >> > > _______________________________________________ > jsword-devel mailing list > jsword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/jsword-devel > > From joseph.walker at gmail.com Mon Jan 31 07:01:35 2005 From: joseph.walker at gmail.com (Joe Walker) Date: Mon Jan 31 07:00:59 2005 Subject: [jsword-devel] Lucene searching improved In-Reply-To: <41F8526D.4010301@yahoo.com> References: <41F8526D.4010301@yahoo.com> Message-ID: <5dd4742605013106015d38ea0b@mail.gmail.com> Thanks DM, this all looks like the sensible thing to do. I've been mulling over the PassageTally thing, but I've not worked out a reason why it was as it was yet. I need to get my head around how it affects best match searching properly, but since it fixes a very clear problem it sounds good to me. On RocketPassage - it certainly used to be the fastest; I spent some time ages ago tweaking it to include the best of the other Passage implementations, however since then you've fixed a few issues in BitwisePassage (IIRC) so it may well no longer be optimal. Maybe I was engaging in a bit of premature optimization! Joe. On Wed, 26 Jan 2005 21:31:09 -0500, DM Smith wrote: > Hi, > > I have fixed the bug in the search where bread returned 20 results > rather than over 350. > The problem was that it was using a PassageTally to collect the results. > I changed the code to call book.createEmptyKeyList(). This uses the > user's choice of Passage. By default it is set to RocketPassage. Is > there a better default? > > I also changed the indexing to save the verse reference as UnIndexed. As > it was the verse was being indexed and stored. I didn't see a need to > index the verse as it is indexed already. And the search logic never > searched against that Field. > > I also changed BookData to skip the children of the
element that > are not elements. The call to getPlainText still gets and > indexes the non-verse text in the element. > > Gen 18.5 in the KJV is an example. > > In His Service, > DM > > _______________________________________________ > jsword-devel mailing list > jsword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/jsword-devel > From dmsmith555 at yahoo.com Mon Jan 31 17:13:07 2005 From: dmsmith555 at yahoo.com (DM Smith) Date: Mon Jan 31 17:12:34 2005 Subject: [jsword-devel] Lucene searching improved In-Reply-To: <5dd4742605013106015d38ea0b@mail.gmail.com> References: <41F8526D.4010301@yahoo.com> <5dd4742605013106015d38ea0b@mail.gmail.com> Message-ID: <41FEC993.7070809@yahoo.com> An HTML attachment was scrubbed... URL: http://www.crosswire.org/pipermail/jsword-devel/attachments/20050131/ed95d68b/attachment.html From dmsmith555 at yahoo.com Mon Jan 31 17:28:25 2005 From: dmsmith555 at yahoo.com (DM Smith) Date: Mon Jan 31 17:27:51 2005 Subject: [jsword-devel] Commit and update access to CVS In-Reply-To: <5dd474260411261351760bf587@mail.gmail.com> References: <20041126174018.24930.qmail@web41623.mail.yahoo.com> <5dd474260411261351760bf587@mail.gmail.com> Message-ID: <41FECD29.3040903@yahoo.com> An HTML attachment was scrubbed... URL: http://www.crosswire.org/pipermail/jsword-devel/attachments/20050131/2809b825/attachment.html