[jsword-devel] FontChooser bugs
Joe Walker
jsword-devel@crosswire.org
Thu, 18 Mar 2004 18:17:35 +0000
Thanks for the patch, it's great.
You were right about CSS support. I wonder if this has changed since JDK
1.4.[1|0] or something, or maybe I was using JDK1.3 at the time I tried
last
I've played with CSSing <a> a bit.
I've also fixed a bug that was causing the Readings thing to sort (or
rather not sort) properly.
There is some more work to be done in that area.
2 things on the patch - I'm still getting slightly garbled patch files.
Before they apply I need to go through and guess where line breaks got
added and remove them and add a space to the front of any lenpty line or
line that starts with a non-space.
Please could you zip patch files before you send them? I would save me a
huge amount of time.
The other thing was this which is probably not what you intended:
> Index: resource/xsl/cswing/simple.xsl
> ===================================================================
> retrieving revision 1.3
> diff -u -r1.3 simple.xsl
> --- resource/xsl/cswing/simple.xsl 29 Jan 2004 10:54:26 -0000 1.3
> +++ resource/xsl/cswing/simple.xsl 18 Mar 2004 14:21:04 -0000
...
> @@ -185,6 +213,13 @@
> <xsl:apply-templates/>
> </xsl:otherwise>
> </xsl:choose>
> + except when followed by a text node or non-printing node.
> + This is true whether the href is output or not.
> + -->
> + <xsl:if test="$siblings[$next-position] and
> name($siblings[$next-position]) != ''">
> + <xsl:text> </xsl:text>
> + </xsl:if>
> </xsl:template>
You've added a comment with no beginning. I guess there are some missed
lines - I just added a start comment.