Patch was Re: [jsword-devel] Passage parsing

Joe Walker joseph.walker at gmail.com
Fri Aug 27 08:34:05 MST 2004


Done

On Fri, 27 Aug 2004 09:26:42 -0400, DM Smith <dmsmith555 at yahoo.com> wrote:
> I have include a patch for AccuracyType.
> I added isBook, isChapter, isVerse and modified 402 to use isChapter
> (and another place to use isVerse).
> I also cleaned up whitespace, and javadoc.
> 
> I have also included a patch for restrict on match bug. This is in
> DisplaySelectPane
> 
> Earlier I sent a patch that was not applied. Initially, I sent it as a
> text file, but because of line wrapping, I resent it on 8/26 as a zip.
> It contained bug fixes and some bells and whistles. (Joe, if you don't
> like the bells and whistles, then you can comment out the lines in
> Desktop.java that add entries to the View Menu) Let me know if you need
> me to send it again.
> 
> DM Smith wrote:
> 
> > line 402 of AccuracyType reads:
> > if (verseAccuracy.equals(CHAPTER_ONLY) ||
> > verseAccuracy.equals(CHAPTER_VERSE))
> >
> > It is wrong. I am fixing it and will send a patch.
> >
> > DM Smith wrote:
> >
> >> I'll look into it
> >>
> >> Joe Walker wrote:
> >>
> >>> Hi,
> >>>
> >>> I noticed a bug in the passage parsing:
> >>> - 1Co 8-9 used to mean 1 Colossians chapters 8 and 9. Now it means:
> >>> "Too many parts to the Verse"
> >>>
> >>> I hope to get chance to have a look in a while, but I'd be glad of any
> >>> insight into the issue.
> >>>
> >>> Joe.
> >>> _______________________________________________
> >>> jsword-devel mailing list
> >>> jsword-devel at crosswire.org
> >>> http://www.crosswire.org/mailman/listinfo/jsword-devel
> >>>
> >>>
> >>>
> >>
> >> _______________________________________________
> >> jsword-devel mailing list
> >> jsword-devel at crosswire.org
> >> http://www.crosswire.org/mailman/listinfo/jsword-devel
> >>
> >
> > _______________________________________________
> > jsword-devel mailing list
> > jsword-devel at crosswire.org
> > http://www.crosswire.org/mailman/listinfo/jsword-devel
> >
> 
> 
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
> 
> 
> 
>


More information about the jsword-devel mailing list