[jsword-devel] Patch coming soon

[Joe Walker]

Sounds interesting
I think SentanceUtil needs fixing, and we're better to do it sooner
than later so unless it is a complex change ...
Do you have biblemapper checked out? If not don't worry, but please
could you send me the patch sooner rather than later and I'll keep
biblemapper in sync.
Thanks,

Joe.

----- Original Message -----
From: DM Smith <dmsmith555 at yahoo.com>
Date: Tue, 24 Aug 2004 15:34:54 -0400
Subject: [jsword-devel] Patch coming soon
To: Java SWORD Developers Mailing List <jsword-devel at crosswire.org>

 I have a patch that does the following: ( I am finishing testing now )
 Verse Accuracy.
 The code dealing with verse accuracy was fragile (huge switch, inside
of switch, inside of switch statements.) So I have re-written it. It
is significantly smaller, tighter, and a bit faster. And it fixes a
few bugs.
 The significant differences are:
 Accuracy has been changed to an enumerated type with behavior (like
ModuleType). I.e. it is a total rewrite.
 ACCURACY_NONE is gone. This kind of thing was needed as a catch-all
for switch statements. It is not needed for enumerated type.
 ACCURACY_NUMBER_ONLY has been split into CHAPTER_ONLY and VERSE_ONLY.
This improved the accuracy of determining what a verse is.
 I added VerseFactory and VerseRangeFactory as the only means to
create a Verse or VerseRange from a string.
 I eliminated #3 as a means of specifying a book and v5 as a means of
specifying a verse. The basic reason was that these were not available
along all paths of  parsing verses. I could have fixed it but did not.
It would not be too hard to add it back in along all paths.
 
 Sentence Case
 I made Sentence Case an enumerated type with behavior. Called CaseType.
 fixed the spelling of sentence (it was sentance), but left
SentanceUtil class name alone.
 
 Blur restriction
 I made Blur restriction an enumerated type with behavior
 
 Passage Constants
 I moved the remaining constants out of PassageConstants into the
class that should be their home.
 
 HTTPSwordInstaller
 Added //$NON-NLS... to the strings. Added some whitespace.
 
 BibleInfo
 removed _ from variable names
 made getBookNumber return -1 if no book is found. Rather than
throwing an exception. Turns out the code was using this method as a
test and get. Exceptions are expensive.
 
 

_______________________________________________
jsword-devel mailing list
jsword-devel at crosswire.org
http://www.crosswire.org/mailman/listinfo/jsword-devel