[jsword-devel] Patch for java/swing

[Joe Walker]

I've checked this in.
There are a couple of things I'd like to spend more time on tomorrow. 
I've not had time to think about the changes to deprecate the String 
ctor on LucidException which affects RemoteException. A brief glance 
said that you had considered the need for literal strings there but I 
need to look more.
Second, Isn't it useful to have Reporter able to display any Exception? 
I commented out the @dep because I was getting warnings everywhere and 
wasn't sure why.

Thanks for the patch anyway I'm once again very impressed.

You even followed my convention of spelling swing as sw*ng outside of 
classes that are in the swing tree so we can check for swing 
dependencies with a recursive grep, to help us work in headerless 
environments. 11 out of 10!

Joe.

DM Smith wrote:
> I have included a patch which does the following:
> 
> Modified EventException to mimic LucidException. Joe, you should rename 
> EventException to something like LucidCheckedException.
> 
> Marked methods in LucidException that took strings as arguments as 
> deprecated. (Identifies i18n problems)
> 
> Added methods to reporter to take a MsgBase and optionally params, and 
> methods that take EventException and LucidException.
> 
> Marked methods in Reporter that took Throwable as deprecated. 
> (Identifies i18n problems)
> 
> Remove the ctor from EventException that took a String. This required 
> adding Msg.java to .../common/config/swing and using it in 
> ConfigEditorFactory.
> 
> In jsword/view/swing/desktop:
>    I moved all strings (except that which should be converted to 
> actions) that should be internationalized to Msg.
>    I moved all other strings to private static final String declarations.
>    I removed all dead inner classes related to AbstractActions. (also 
> did this to SitesPane)
>    I added the ability to open the config dialog from DesktopActions.
>    I removed member variables which did not need to exist.
>    I made the showing of debug tab optional on the About screen.
>    I added the ability to do the same for all the other advanced stuff 
> on the About dialog. It needs to be tied into config.xml for it to do 
> something.
> 
> The following code is not used by the JSword GUI and could be removed 
> (unless it is there for future use):
>     ComparePane
>     CompareResultsPane
>     DesktopAbstractAction
>     GeneratorPane
>     MaintenancePane
>     LogPane
>     ComponentAbstractAction (if we get rid of LogPane)
>     EirAbstractAction (if we get rid of ComponentAbstractAction and 
> DesktopAbstractAction)
>     EirPanel (if we get rid of LogPane, GeneratorPane, MaintenancePane, 
> ComparePane)
> There may be tests that exercise these.
> 
> _________________________________________________________________
> Persistent heartburn? Check out Digestive Health & Wellness for 
> information and advice. http://gerd.msn.com/default.asp