<div class="gmail_quote">On Fri, Jan 14, 2011 at 12:06 PM, Greg Hellings <span dir="ltr"><<a href="mailto:greg.hellings@gmail.com">greg.hellings@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On Mon, Dec 13, 2010 at 2:44 PM, Martin Gruner <<a href="mailto:mg.pub@gmx.net">mg.pub@gmx.net</a>> wrote:<br>
> Hi Greg,<br>
><br>
</div><div class="im">> I like your suggestions and your implementation proposal!<br>
><br>
> For module specific stuff, I'd recommend to put classes on the <body><br>
> element, one for the module type ("Bible"), and one for the specific<br>
> module ("Bible_KJV"). That gives you all freedom writing your CSS.<br>
<br>
</div>I have made this change and pushed it. Obviously it doesn't work as<br>
intended if there is whitespace in the module name. Crosswire does<br>
not allow whitespace in there (I believe) and I don't think Karl has<br>
any in his modules (though I say that without having actually<br>
checked). I only noticed the problem because I have some personal<br>
modules which are rather poorly named ("A Grammatical Aid to the Greek<br>
New Testament"). One more line of code could easily change the spaces<br>
into underscores or the like if we want to consider the "broken<br>
module" case.<br></blockquote><div><br>Didn't notice this before, but if I understand it correctly you have "Bible Bible_KJV" rather than "Bible KJV". I'm not sure why you would do that. Is it deliberate? Is there some good reason why this is better that I'm missing?<br>
<br>Jon<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
If other people are happy with the changes still, feel free to pull my<br>
branch (I updated it as of 10 minutes ago by merging in master to be<br>
sure of no conflicts).<br>
<br>
The extra CSS changes made below I figured ought to be considered more<br>
deeply by multiple people than just me and could make a natural next<br>
step from here.<br>
<font color="#888888"><br>
--Greg<br>
</font><div><div></div><div class="h5"><br>
><br>
> With the CSS, you could go one step further and consolidate redundant<br>
> CSS from the different templates into a basic CSS files which is always<br>
> preloaded. Then the different styles only need to define their<br>
> differences from that. Example:<br>
><br>
> .sup {<br>
> vertical-align: super;<br>
> }<br>
> .sub {<br>
> vertical-align: sub;<br>
> }<br>
> .right {<br>
> text-align: right;<br>
> }<br>
> .center {<br>
> text-align: center;<br>
> }<br>
> .bold {<br>
> font-weight:bold;<br>
> }<br>
><br>
> This stuff makes sense everywhere and should be consolidated. It is not<br>
> really style-specific.<br>
><br>
> Right now I don't know if different HTML skeletons are really<br>
> neccessary, but the option of having them is certainly not bad.<br>
><br>
> My vote: good, can be improved, should be included in BibleTime master.<br>
><br>
> Regards, mg<br>
><br>
><br>
><br>
><br>
> Am 13.12.10 16:02, schrieb Greg Hellings:<br>
>> All,<br>
>><br>
>> I've mentioned this in #bibletime over the weekend, but figured I<br>
>> should state it here, for archival purposes. I have pushed a branch,<br>
>> named 'externalcss', to<br>
>> <a href="http://gitorious.org/%7Egreghellings/bibletime/ghellings" target="_blank">http://gitorious.org/~greghellings/bibletime/ghellings</a>. The purpose<br>
>> of this branch is to move the styling CSS portions of each of our<br>
>> templates be moved into its own, external, CSS file rather than being<br>
>> embedded in a complete HTML template file. The hope of this change is<br>
>> multi-faceted in nature.<br>
>><br>
>> Firstly, this allows a template creator to only mess with the CSS<br>
>> file, if they so desire, and not need to worry about keeping an HTML<br>
>> template file up-to-date. To create a custom CSS, simply modify or<br>
>> add a CSS file to the share/bibletime/display-templates/ directory of<br>
>> your install and restart BibleTime. It will then be displayed in your<br>
>> template file list in the configuration dialog.<br>
>><br>
>> Secondly, this allows a custom HTML structure file to be used if one<br>
>> were so desired. This can allow the flexibility to add or detract<br>
>> from the files while still maintaining easy inclusion of the current<br>
>> CSS files with no need to modify multiple HTML structure template<br>
>> files. In the future, if more of them are generated, these could be<br>
>> presented to the user for selection in much the same way that the CSS<br>
>> files currently are, or they could just be used for anything internal<br>
>> that we wish to require different HTML skeletons for.<br>
>><br>
>> Thirdly, my personal axe-to-grind is the ability to add support for<br>
>> individual module CSS files. I have currently only added and empty<br>
>> hook in the HTML template file for the attaching of the module's CSS<br>
>> file, there is no attempt to fill that hook with anything other than a<br>
>> blank string. I intend to write that support and push an additional<br>
>> commit to gitorious with this support. I know some people oppose this<br>
>> idea, but I am in strong support of it, especially with some of the<br>
>> potential it provides for giving the presenters greater control over<br>
>> their modules while still allowing the user the full range of control<br>
>> and configuration if they so desire.<br>
>><br>
>> Take a look and check it out. Let me know what you think, and feel<br>
>> free to pull what you want out of it if you like it.<br>
>><br>
>> --Greg<br>
>><br>
>> _______________________________________________<br>
>> bt-devel mailing list<br>
>> <a href="mailto:bt-devel@crosswire.org">bt-devel@crosswire.org</a><br>
>> <a href="http://www.crosswire.org/mailman/listinfo/bt-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/bt-devel</a><br>
>><br>
><br>
> _______________________________________________<br>
> bt-devel mailing list<br>
> <a href="mailto:bt-devel@crosswire.org">bt-devel@crosswire.org</a><br>
> <a href="http://www.crosswire.org/mailman/listinfo/bt-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/bt-devel</a><br>
><br>
<br>
_______________________________________________<br>
bt-devel mailing list<br>
<a href="mailto:bt-devel@crosswire.org">bt-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/bt-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/bt-devel</a><br>
</div></div></blockquote></div><br>