[bt-devel] Proposed change for BibleTime

[Daniel Owens]

Hey, if you want beta testers, I am happy to help. I don't have time to 
get set up with a development environment, so a compiled version would 
be nice. Mac or Windows would be easiest.


On 10/4/18 11:08 AM, Gary Holmlund wrote:
>
>
> On 10/03/2018 01:41 PM, Jaak Ristioja wrote:
>> Gary,
>>
>>> Auto scrolling of the active works window. Start scrolling with 
>>> Shift-Up
>>> or Shift-Down. Increase speed by repeating Shift-Up/Down. Use the space
>>> bar to toggle the pausing. Hit any other key to completely stop. Also,
>>> changing the active window stops it. The shortcuts are in the main
>>> window group and can be changed using the Settings/Configure dialog.
>> This too is very awesome! =)
>>
>> Except that I would have expected shift+arrows to work in the opposite
>> direction, e.g. if I push shift-down, then I expect the document to go
>> in the same direction as when I would push (page-)down. I would also
>> increase the autoscroll speed limit.
> After thinking about it you are right. I switched the directions.
>>> Changed the Copy context menu to ask for the first and last key name
>>> that will copy to the clipboard. It can copy an entire book of the
>>> Bible, but it does have limit if the first and last are to far apart.
>> I get these two warnings about this:
>>
>> WARNING: QLayout: Attempting to add QLayout "" to
>> BtCopyByReferencesDialog "", which already has a layout
>> WARNING: QLayout: Attempting to add QLayout "" to
>> BtCopyByReferencesDialog "", which already has a layout
>>
>> I didn't look at this code, but in my experience such warnings usually
>> occur when you construct a QLayout giving a QWidget as parent (which
>> sets the layout of the parent widget to the layout being constructed),
>> and then later pass the layout addLayout() or similar. In such cases I
>> suggest to omit the parent widget argument when constructing the layout.
> You are right. I removed the parent during construction. Fixed.
>>> The Personal commentary can be viewed like any other work. Now you can
>>> mouse click a verse and a dialog appears to edit and save that verse.
>>> You no longer have to open a separate "write" window to edit the
>>> Personal commentary. This works even if the Personal commentary is part
>>> of a parallel view. I believe it works so well that the "write" window
>>> functionality should be removed.
>> I like the idea of removing the "write" window functionality. While
>> mouse-clicking a verse in the personal commentary seems to work, it is
>> not intuitive at all. How does the user know that he should right click?
>> Please also take a look at the attached screenshot. There are no
>> headings between sections in the personal commentary nor are the
>> boundaries of verses clear. There is just a whole lot of whitespace one
>> can accidentally click on.
>>
>> I think that while this concept needs a lot of more thought, it is very
>> positive to think in that direction, because using personal commentaries
>> is quite unintuitive in the current BibleTime.
> I added a border around each verse in the Personal commentary. I added 
> the chapter headings.
> Also, when a verse is empty a prompt "Click to edit" appears in the 
> verse area.
>>
>> Since the copy context menu feature and the personal commentary feature
>> are distinct from the scrolling features, they deserve separate feature
>> branches so that it would not interfere with developing continuous
>> scrolling. It also makes code review more difficult.
>>
>> Originally, this mailing list thread was also about the scrolling
>> feature only, but now were talking about multiple different features and
>> this is a bit confusing. I understand that these other features might
>> also be related to the scrolling feature in one way or another.
>> ---
>>
>> One other issue I encountered is that one can no longer just select text
>> from the read window.
> I should have explained my reasons for this better. Because of using 
> the model/view approach, it is no longer possible to select arbitrary 
> text at the word level. Selecting a verse or entire verses could be 
> possible. I felt that having a copy dialog where the user can choose 
> the start and end of the copy would be the most friendly. It is 
> replacing a feature which would have been missing due to the 
> model/view approach.
>
>
>
> I have pushed these changes to my repository. The mv2 branch was 
> deleted and rebased on the lastest master branch. Perhaps it is time 
> to push my work to the main repository.
>
> I have not yet deleted the "write windows" code.
>
> Gary
>
> _______________________________________________
> bt-devel mailing list
> bt-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/bt-devel
>