[bt-devel] Serious personal commentary overwrite bug - FIXED

[Jaak Ristioja]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02.03.2011 07:59, Gary Holmlund wrote:
> On 02/26/2011 07:55 PM, Gary Holmlund wrote:
>> On 02/26/2011 06:02 PM, John A. Sullivan III wrote:
>>> On Sat, 2011-02-26 at 19:39 -0600, Greg Hellings wrote:
>>>> This problem sounds straightforward to fix if it truly still exists.
>>>> However, Bibletime 2.5 is woefully old. The current release is either
>>>> the 2.8 or 2.9 series, and I'm fairly sure 2.5 is no longer under
>>>> maintenance.
>>>>
>>>> Can you upgrade your version of Bibletime to something less archaic
>>>> and tell us if the bug really still exists?
>>>>
>>> <snip>
>>> That's interesting.  I'm running Squeeze which was just released! I just
>>> tried an apt-get install bibletime to pull in the latest and it told me
>>> I already had the latest :(
>>>
>>> I'll check the Bibletime web site when I have a chance and see if there
>>> is a Debian repository I can add.  Thanks - John
>> John,
>>
>> I just tested the latest code and did find a problem. It is not quite
>> as you describe. I had the Personal commentary synced to the Bible
>> window. I edited a comment, went back to the Bible window and
>> incremented the verse. I was asked to save and I did save. It looks
>> like no entry was changed. The text I just saved was not saved.
>>
>> I will look further into this.
>>
>> Gary Holmlund
> 
> John,
> 
> The Personal Commentary bug has been fixed. It is checked into the HEAD
> branch of Bibletime.
> 
> I did find that text could be saved to the wrong reference just as you
> said.
> 
> Gary Holmlund

I also backported it to the stable-2.8 branch and I think we should
release 2.8.2 soon after it is verified that this indeed fixes the
problem. Some of Patrick's fixes should also be verified and merged to
master and stable-2.8 branches (there are already merge requests for them).

God bless!
Jaak


PS: HEAD is not a branch, it always points to the tip of the currently
checked out branch. The main branch of Bibletime is called "master".
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQgcBAEBAgAGBQJNbfQXAAoJEHeFv6jk2xWmnBo//2p2jlPyZivoYtnN5qM8G3zM
Q11jayugSX+K7VmT72kvSqM07pk+Lb0SmNdI473ft7IceoQT6MtkdKv55F/X13Cd
7dUvE0R/sch5cNo06e8zCsZfccUm0ZA/d3VZJ4yvL6d79+CEoDAXXJnLkefGMk+H
+hD8T5obX0FlzweHUbueNxsiwgrtioUnqpOFzpwEg0F90LqtTcgd5BR7EEbr2T2V
YoVirLVi9ETCLi3Sa1YBvuwki/O8z+jiC0LuyBYwtrF1gdcW5tvqn0npa18MATI5
l5NIUE1r9jK4jxCftnejhiMAIASNwekwXLCAXaXB10nR4rSmXFSkQWwntybdVHo2
OnXCzImXHOF5oa5ehhLtc064Z9DPotF2GMzGoeKlhpN1twATTjnHN0qYdvKDc0GV
cj11oWAvLNvrC/edK2wdlgcqNUMbk/1qUWIPNYkHGQgsdhlWyRQMsQACsH80AQDI
RZ5uZ046zOg9me0hAaezwsF9b4XuAWC7BzgnBHX9hBrk63oNdblmPEktUEZRMMo9
Jm7qz75K8Mo4vHojWG1YLm4LOxzCYMgePLfZGOH5GQBGhfwH6oMRgLbqOGQM0/PF
6Yaf01YhODkN/9uGDoh/BImxiQnBzS74vfvECrrBhzWmilhtEiWDmyfO+t8BHquC
GX+vMuue6nh0tWjGlf91IKwjJBRS2cTzTeVEuqgD4ZWfwf7Lhg/It5AkuDo6cLRk
2QZpoEAUduxhgifKubGDUeTFH3waYd1jLi4Aliezv0wRqbbvHz8DFTVnUVpd4MUS
D5AMcFObzYg3pnbwzSGPoDZpfAxhr8ODjDL4iDwO7P+GNSTWUnluwJl6lKw7jIwa
23/LQzTvEi4aDcNh1NcHO/GUSdei781UO6raNf80wM9QvTVEHakliecKPdWwYBra
w6XbDVZGx/T15D9lh3awCAohqDC0RqUNQgb+XPpBKSDBVk0i51utWkDC6wesHGwe
y4xIj+G0F2+kqQwAWBUKXrZclzBUIht9PAcICaYW+0SZfKZekisn2qKRmx1IusWt
mOP7/zXceG5a5NExD3ypA1ZBF2Y4gurREOyneUJEm9WPxafkfDuEQDL5AWG+1Fpe
9DJylnYQOJlCU3dzAtL1b8okQEvOylcmRLGLfkZFdHx8Hs8kZ/gzWNDgvcBYRskI
zwaFAnZ6Kjno+3o+NEXRRpYIu47EffVfXSZSJzRf98rQDrGJsgBhj5a8NfB0N/59
QvIqLTG4Mywgo//CNY3V3Y3zZTizel5WOONVyCndWjH3jBP+OeROdc0lLOh4nKZ+
Kz8lSjk+oOOE4FHoiUTR2NEW2mTGP0eAr/P6u2gbpicb+Z19VvxInPLcNhXPiExb
rjd/YUUUvkx2RxZjIwbEEL6NHcZkci6YCBWBwd4QFgGlVjOOfsBpzezd1r58SvTD
Of9XEthKt4q9uXfTgPcLlbEtFVj02y4iGwAe87zq2UCaK9UhZoT+ToLZpIzR9Irr
9UK5YEQmYotBu4YzeOgbl0bjgzmefrlnS7WinVS+C3mzDMBZi65oELPfAqmV02hG
Lk6TjF4ezByhec+1JnYyIOcsbgMN+D646v0DWP6Eg5RUvndiGj6or6b/AqKS5mBF
osGAvtUDIlokM6Jx9elbaJVv9xiww5rP/8qP3Tit68Y7SmNqOO3NL0rdVtdnFv3B
XO2YsVXVERN9J+g6UbwdTIjZXmWzZtB+WYRYrWYyVbXDESyDmedRqq68moGUu+Pe
A6bIxfMNdM2K7YPXn4wXDwHVV7+/X1UPieYNST1GQc5DW6icz+auOkUYDJ0EJTMN
G8M1zjOBtMsQUmPtCkjpSQuUlOiCaZXLP+ntVC9hP3af1oUwVES4rHOF+hDj/zCF
6DlgyKEoCL1iV5++JHEjxfXfuUXYbYlgFIKuNgh+IoyKCxu2INJRi0haKVg0KlE7
Fm0ZjZI3cHXY0j2T5JhNnViuZhjVnprnGIdqQxfZNK6uHb0kOkW0N5N5GKgbXZ8x
bjclovlr+jL1saMUGq5oSp5SOKfsXBhHY8CEkE53+Lkl9Ui9dwrCAyMsRyRNC7BJ
TqIlZFOUwD2eLsJ03gZ9IfPcA/ec1x1FGXQxmd+bbIkTvh212uDtkCqE2O122Ueg
GVGRkgIbN4yoz5sWmDZbG/Dnh3are2xgMsReEqvUYt+YIjQw3pOS+38jw69t2+0T
E2MgelsIT9VdLkxOm1tOSh05CeVZ72XzGz3T3Rnv2IqFxN5vhsTGx66FaZSKy+W+
jQBtDtS8nGIC2bbo8Pj5NyBNP8yhTwIfprQBmg41R1IZhfvs+qwQRBT7g2hZQNiA
ykikQH+gTceT7VhgWqCEFeAra13dmMrpfrBGtNWxbthWAqt66AfdBKqbldR6THQr
G5DMbKaGGm1CoUGOGZgC15YAh0EPWbzb2Ixj4Wtw7OpxHKMPbtPXqx2qKvZmUKsg
jWX2YDmjKatzSQOr0BqkZszJDVNf/rPyeSj3nq82qqrH3iShijwQ6aqy1EKwQzy7
Vs1xxZ8GJ5+heR6NnlPjGyQPrDS99O8dobRwTnKRQCQxVucF83snh7rj/wpSw98d
T/dSCa8wbip62AbQtdNfD63P3G/2/OEjd4Z9qwBvKP9tQgOlWNOu/FkbULFagJCL
uYdJoZTpTHt5l8PSpkhIDsLRWhm3zXhvW3oTnAlDYt2cuW35ti8ajcQRh1Kr7Wzd
VxQPwIgN+4G7fYKE6RZm
=ZNbC
-----END PGP SIGNATURE-----