[bt-devel] Backend Proposal

[Jaak Ristioja]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ok, I tried to compile and run your code after you merged master. It
compiles well. I noticed that btconfig.cpp there are two places where
deprecated Sword code is used: "list.GetElement" should be replaced with
"list.getElement".

You also noted that it crashes when you try to run it, just as you
documented in the commit message. This is because of endless recursion
in the following 6 functions:

  QDataStream &operator<<(QDataStream &out, const
Search::BtSearchOptionsArea::SearchType &searchType);
  QDataStream &operator>>(QDataStream &in,
Search::BtSearchOptionsArea::SearchType &searchType);
  QDataStream &operator<<(QDataStream &out, const alignmentMode &x);
  QDataStream &operator>>(QDataStream &in, alignmentMode &x);
  QDataStream &operator<<(QDataStream &out, const
BTModuleTreeItem::Grouping &x);
  QDataStream &operator>>(QDataStream &in, BTModuleTreeItem::Grouping &x);

I might continue verifying your code in the next two days if I get the
time. I hope you can get it to run more-or-less. :)


Blessings!
Jaak


On 23.06.2011 11:17, Patrick Sebastian Zimmermann wrote:
> One more file to merge until the first compile.
> Rest this evening.
> 
> Patrick
> 
> On Wednesday, 22. June 2011 18:17:45 Patrick Sebastian Zimmermann wrote:
>> Hi,
>>
>> I'll see if I can get this done tomorrow morning. The two other merge
>> requests I'll leave for later since they are just bugfixes that can be
>> applied at any time later just as well.
>>
>> Greetings,
>> Patrick
>>
>> On Tuesday, 21. June 2011 23:55:32 Jaak Ristioja wrote:
>>> On 20.06.2011 21:24, Patrick Sebastian Zimmermann wrote:
>>>> I have a pretty much finished rewrite of the config system in a branch.
>>>> The changes include a unit testing framework (based on QTest) and are
>>>> meant to unify config option and session handling. The code probably
>>>> still has some bugs, but I have tested the code quite a lot and I think
>>>> I got most of the bugs out already.
>>>
>>> I've tried to review your changes several times, but never finished.
>>> These are big changes and take a lot of time to review. Last time I
>>> tried was months ago, so I don't remember any more and need to start
>>> from scratch again. It would help a tiny bit if you could again merge
>>> master into your branch and also my merge request.
>>>
>>>> I am not sure whether you think this config system refactor is a good
>>>> idea. But if you think it should go into master it really makes sense
>>>> to merge before starting the frontend/backend refactor.
>>>
>>> I believe you've done a serious amount of work. We should definitely
>>> work this out before any other major refactoring efforts start. I
>>> suspect that this won't be an easy merge, but I'm willing to study your
>>> changes and try... when I have time...
>>>
>>>> I am currently very short in time, but if it's not much that is needed
>>>> to get this into the tree I can at least give it a try.
>>>
>>> Same problem with most of us. :|
>>>
>>>> ps. There are three smaller bugfix merge requests still hanging in the
>>>> queue...
>>>
>>> I merged one of them, and commented on the other two because they need a
>>> bit of clarification. I don't yet fully understand the problems they fix
>>> nor am I sure whether these fixes are indeed correct.
>>>
>>>> On Monday, 20. June 2011 00:46:13 Greg Hellings wrote:
>>>>> On Sun, Jun 19, 2011 at 4:54 PM, Gary Holmlund
>>>>> <gary.holmlund at gmail.com>
>>>>
>>>> wrote:
>>>>>> I would be willing to do the structural work of moving files into new
>>>>>> directories and changing the backend and rendering into libraries. We
>>>>>> would want to get agreement on the details before any work starts.
>>>>>> The work should be done so that there is never a commit that does
>>>>>> not compile and run. It can be broken down into a series of small
>>>>>> steps that accomplish this.
>>>>>
>>>>> It's probably good to identify one component at a time to pull out of
>>>>> the code base and do it that way.  And it probably should be the task
>>>>> of whoever is going to take the reins for that component to move the
>>>>> files and modify them as necessary (in connection with people working
>>>>> on any components that rely on it).  Since each component probably
>>>>> requires more than just copying the files to the new folder structure,
>>>>> it's probably best for each component to be done in a branch of its
>>>>> own, that way every commit on main works even if there is some
>>>>> breakage in the branch. It also allows for multiple people, such as
>>>>> the person creating the component and people working on components
>>>>> that rely on it, to collaborate on factoring out each piece. Due to
>>>>> the interconnectedness, commits on the branch may not work but we'll
>>>>> be sure the project works before merging each component back onto
>>>>> main.
>>>>>
>>>>>> I wonder if 3 components (backend, render, and BibleTime) are the
>>>>>> right breakdown. There may be other things we should separate such
>>>>>> as the config system.
>>>>>
>>>>> I'm not sure what our config system does that isn't part of the normal
>>>>> Qt cross-platform config system.  I would have guessed that any config
>>>>> systems would be part of the GUI component, but you probably know
>>>>> better than I.
>>>>>
>>>>> --Greg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQgcBAEBAgAGBQJOB1CfAAoJEHeFv6jk2xWma2s//Aj3w/Paab6Gu5Qm2K0qH/Vs
27xXOqzApyG5jQNGn9xg0ntomCdxvP93WPQp5g7Nl1eZ0oVT4dKFn7C4NmRPU6i7
gBHJ4VxvC5EMzupwq2EHWGvsN9OauimsfHquSI7hB5Hqf2FhGHyGnJOK0PknDz3w
xjlNephjS9GWwL1mkxLCvBRWyipQpX6gNUe2oJxVsN4ePlNYAtmVULrAB4DqXs0d
eivKckdstLC13VEcszo5n4HemMYdKKBVBHPMPUG0uCZB+hAsBpJkSXTBV4HWZ//e
SIff3rG/9jqxMN/e89GYVf/wNkBB9eDwTABf0npX8fckMw/TowAWBzgVMQB5ix+2
FL1LZSTuM12ThwpNS3RTEXhbb53TfX5WbKf15PwtIRKAXpJ7f2pv3TMxfvCjBBBN
k2rN5k75qo8qveACGrtgzjYeRjwaD41CpnZhpp7ESlmmbZSx5azKit+wTK/gsQnF
4oGRzj6ttAIscI5iyg/A8rrhR8LuSyT67F1SWoVy4I1yhCFd6hWZqnfbOvPEUcjy
cQHDLBdiKD1VOKtkfC+DvTsEbnm4RKVU3+mj4NBsOKG1KRYszdIaDSC+nlSETn0J
KkJK4aXwav+xr8vNBssEasqL3jhdQ5yWeAX6pwb0fGkVqaJUknnfjDE6wzxmjdUM
gayW8TA0V1l676VBkfteV8W7NAHlYXw0C+PX3vbtubuV1nNgtmKz/dnAK0OV4isO
rpw8xq77Cme3z4ojTjt6Peps9TrXp3yoZmDNOrIQZeJ/ZdIExk5ZgvwodCjg41xc
lnXc7a4Vav/oAbmobLPQkZIw4ERz0ji09DDrckoFA/10q03+WBOTN9NGlwT1BgFH
eV2V4C+c90SxTYTpwiG/dKXi9ZliVQbIygN3FA+F5KYbccESfGAChxHLidn0OZkj
Rw0cKd0KTIifhZgFR+ZKXCQey22GfiiktOac1Dgj/v91yPbwmWPE+N62DaOFXdfK
auETvkW5+pXkQlQRcdTGsgCWN9NK5gss8GuQpy5FYKPsmQey6rV5+FCAdUfuFUQw
1nXMxJfXCy7Rfyk65qvdDdUH94MAKG4LuCqSm3+7hcK1KOkV8s/TtjD9VHTbo+lY
uCR5LNVJaVowAeoMmh2pYkWH2VfLMB6CxjhDEbBoIF3S++JCHtbxteRK/Oj5RXii
5LcVojbUPwEA5rkiPmdCX+RCeQ/EpbXduSnvjtSYl5XlL31nB8W1Ojw4gHg3IN4g
OqY92yvLOF+qzM1FGk2wLscbFt6QVAzqqZ+5IWUIF3P1zAHzCrxI4JzndIRmvSDb
7ZIefQ9i9pCxeD+57jo22Hlv0nVbLG6jOWl16vDgRLT7rRQ/fgV/7o3PADFv4NJg
ZRJFYzfGjyuKYy545tMaUaHMlsWBJidncPq3rOeETN8ThBaNuH7vG/J2VvW9/mbw
AikkVMOgke/V83L7eSzAbiPVO0VKrj7kyaKD+/To3Jp/XmLmkLsXzkHxN25NeRrb
saDR8c2AMjteIVhy3CPdleX47NAnhS1yElrL/w8b5FmrvZc5EZwp/Ks3YMxYkCjo
r7YPpo3pF8cngt9BE/a0/44WLbzOl9+ntxa1GNlWLbw98/mmhfv+Rsiv1O1x4OW4
AvJPq7/FQ1Bqni9nuIkq2sc+X8HJCtpezUwx0MmvrQsr/2pasNx662z6b3+6Xvy5
mU0LgPMJbyb/6dCUupOX8JLfRQ1En6mRIc5YepoHEPPI9cB9MDguRMDG4fcmStaN
fQKLqbslhpcrYoDFKd+3vQ2go/9FR2U3GqpSgVyfZGkwwKLBnY4Xgx8lxROwS2vp
kxD9r6+POv5mOf49nkQCt+woCbhIhAWNd0S4RFGhiePjWLvfzSU/eBQENh+qkMjB
Nq2OXg+D+IikjzcVk8yStIaUPtjQNna+q7LmVrjllC6HErgWXevKSrGoOippMBAA
Wm+3sa1b2LKnJyJk4mN1cvFqG3k4DcdEtCFgcuakUwF333//F2x1zsfZWbX8FHE4
fHGbBwvx7A+XCH+po5Dusby6f91X6l8ZehBXpKAMgKpjb8w3jOEGjygX6+r8Xspk
23JhDc0Q0YKAaxmtDzHhXt/2Bjq1m5r/Ul1cOYDx0rNEB4NPKpHyAwwcU3PRdv0S
dK/z0XwPDsjYz2F53R7Plu1T5rrlcaGO1ECG4QXYmGiCiS0OiGJZkIbYyx9Lt/kV
EZ9RGhQ4FnMvu7IwhFhryYKit1xQc32MATQUZIQJDP+190+kVWIiS+zU1fq+g7JX
ayzF39E1/fOu7KpPdHFkFvvLHayWs5CJUTYuBmixuurImUXkNYWpS95FpHxumX14
CYXpG2MlkQbFV9hj4DyqrL/04B9ssPBTLjpilLAGxu4lgFwDOKBnyrLRJeZAL1mN
ABqmd7wP2z1bW7A/PabxzkZFEoVJsF2pbUZdL4MsAqbhPudV188hXMtnR7rh3F80
/YQ+T1DhdObItuqz8Wo3L7mJUud80HjseJ54QgNzLYM/B/23rLMNjPeRpzrCLZim
6q4XgXdffYWGMWgoOHXV2tHBuQX0Jos7crlaYs4Iy3LzPPQ+OiT4SmxA9eay4+l/
qYYo9iOq8HqTw5KFy8t/k3EiDkg0iRQpMZjh2tp0YOIWJexW2GNTK6YyMRIVnp84
EwmvD09jw3Y51w5rSgcBaeITwdZdvZ3Bc8Sl9mCEaO6JNjDdsfzgvdN2csOeSU9t
Uag1hHZhAADpuuVGAcbL
=69Wn
-----END PGP SIGNATURE-----