[bt-devel] Close button on tabs

[Martin Gruner]

Hi Jaak!

Thank you very much for your recent commit regarding initBounds(), this
seems to fix the performance issues I had with the Bookshelf Manager on
MacOS! It would be great to have a new release with this fix.

QT 4.5 is minimum: SET(QT_MIN_VERSION 4.5.0) (from CMakeLists.txt). We
might think about raising this to introduce some other features related
to the JavaScript integration in future.

I did not know that whitespace at the end of a line is a problem in our
sources?

Regarding the bugs: I like the bug tracker at github.com. It feels very
natural. And github now also supports organizations. So maybe moving the
project there from gitourious would be an option?

We use bugzilla at work, but it is quite technical. It does allow for
very fine-grained classifications etc. Depends on the main goal of the
bug tracker. Sourceforge offers Mantis as a hosted app...

Best regards, mg

Am 20.08.11 09:54, schrieb Jaak Ristioja:
> On 20.08.2011 06:22, Gary Holmlund wrote:
> > Jaak,
>
> > I was looking at the feature requests and saw that the request to add
> > close buttons to tabs would be easy to do. I checked it in a bit ago. I
> > did not realize that you had recently assigned it to yourself until I
> > went to close it. I am sorry for not checking this first.
>
> > Gary
>
> Hi Gary!
>
> No problem. This is not high-priority thing anyway. Thanks you for your
> contribution! :) I took a quick look at your commit, and I have a few
> small questions/issues about this:
>
> * Are you sure the using findChildren() is ok? I mean it's recursive and
> could match any QTabBar in the QObject chain. Maybe we should explicitly
> use a QTabWidget for this MDI type.
> * setTabsCloseable was introduced in Qt 4.5. Can anybody recall what was
> the minimum Qt version we require?
> * Do we really need to use disconnect() there?
> * Changelog entry had extra space at the end of line (git diff printed
> it out RED)
> * #includes appear to be in non-alphabetical order (would be easier to
> read imho).
>
> Feel free to express your opinion and argue with me :)
>
>
> Many blessings! :)
> Jaak
>
>
> PS: We should really consider setting up a better bug-tracker than the
> one at SourceForge. I have a strong preference for Bugzilla because my
> bug-reporting experience with projects like Gentoo Linux, Linux Kernel,
> KDE, GNU GCC, RedHat etc have been mostly very positive with it. It
> provides a lot better email notifications. I might try to setup Bugzilla
> on my home server (just got a lot of more bandwidth) at some point...
>
> _______________________________________________
> bt-devel mailing list
> bt-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/bt-devel
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/bt-devel/attachments/20110820/c6a7fb47/attachment-0001.html>