[bt-devel] alternative GUI

[Jaak Ristioja]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 22.07.2010 18:11, Olaf Radicke wrote:
>> Personally I suggest, that you might want to clone
>> the git mirror of the SVN trunk from
>>
>>   http://gitorious.org/bibletime
>>
>> for your current development. That mirror is automatically updated every 20 minutes from
>> the sourceforge SVN repository.
> 
> Can't login gitorious. No  error messages. No idea why. I hosting my clone
> of my owen server:
> 
> http://www.fkbk.de/git/

It works fine! :)

>> I have the following remarks about the patch you sent us:
>>
>> 1) Conditional compilation. I think the alternative GUI should only be compiled if
>> explicitly enabled by specifying some arguments for the "cmake" command, e.g. "-D
>> BT_ALTERGUI".
> 
> The new GUI have only a part of BibleTime features, so sometime the user need
> switch to old GUI.

Since you're using your own git branch, this might not be a problem at all. At least not
now. :)

>> 2) Source code formatting issues:
>>
>>   * Use m_ prefixes for class fields, so that we can use "m_fieldName"
>>     instead of "this->fieldName".
> 
> That is a point, which I do not understand! If i use 'this->' it is a
> little longer, but the compiler is warning, if i err.
> 
> 
> void for_exsample_checkClassCount()
> {
>     int my_count = 10;
> 
>     // error! meaning is 
>     // if(my_count > m_count)
> 
>     if(my_count > my_count) 
>     {
>         m_doSomething();
>     }  
> }
> 
> void for_exsample_checkClassCount()
> {
>     int my_count = 10;
>     // compiler 
>     if(this->my_count > my_count) 
>     {
>         m_doSomething();
>     }  
> }

I think that "my_" is never a good prefix for any identifier. In addition, initializer
lists in constructors are easier to understand if we use prefixes:

    SomeClass::SomeClass(const Type &fieldName) : m_fieldName(fieldName) {}

instead of

    SomeClass::SomeClass(const Type &fieldName) : fieldName(fieldName) {}

>>   * Don't indent classes/structs inside namespaces, only inside other
>>     classes, so we have more space to fit the code into the recommended
>>     80 character columns.
> 
> I do not understand that. an example Please!

Good example:

namespace DoThis {

class SaveSpace {
    // Stuff here
};

} // namespace SomeNamespace

Bad example:

namespace DontDoThis {

    class LessSpace {
        // Stuff here
    };

} // namespace

>> 3) Use QCoreApplication::arguments().contains("--alter-gui") instead.
> 
>  Principle okay. But it is workt before 'BibleTimeApp app(argc, argv);'?

I don't think so. Do you need it to work before that?

>> 6) Source code file names are in lowercase.
> 
> Bot it's ease to read. For example:
> 
> http://bibletime.svn.sourceforge.net/viewvc/bibletime/trunk/bibletime/cmake/

Yes, but it's also harder to type (except on Microsoft Windows, where filenames are
case-insensitive). And all of our source code filenames are already lowercase.


Blessings!
Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)

iQgcBAEBAgAGBQJMSGgCAAoJEFqwhAoGc/hv1F1AAKecUXvKuetAK6FzZqMuWRuN
teUGEyMq6eUngCqNr/6jqxu3hXBK05MFO66JzKhEsNVbT25D4aAJrzUfIZxgc6DT
0XCWWpHSbEGqA8+Pqi2UVL7a/ZUezzNVu0C9jW5Ov8cHLhJ54CedvX9Cn/gAQZ8l
gmyEruI4UtxfPaJWcVfAvIxDtb15eDqmznLkF9zK2QsfFc5Z9bRXXJrqLd8CLVxI
X2acx1pNux7I66qa56W56oKQ/5G4E93mcdRMCbFZdF7DmDvYVvTkk8yhpRKPa2l9
dBz6JGbTlgnS/wvTB9RHRATeGKxmpO1WGC466eixgRapMbtE2wj70XIaXOlRV0ni
SQaym4fjcdxF+a0GlQ+BNanJfe7EIj2NwNvIppe3dz/gQ1K1e7VmyNxjdaQn/zTD
m5Q65eOal9okaTc23kIrbf6+cpFtziJZXrCyE3Db7+xaSgUVvkhpaOiHusoyt2Au
fDG14DBeuah//B2/dmHaz/CSVTp4f0/VJ//HOLLh15+LaPK9N7XtxxaloWUPpQBF
ao8W4o3CVRVp74afhJubMQ5STrVlxcrNmTokhCEOXsI0gaSBCjcGMhIVrOvpjaQu
qC6EKe+NYxuQHpH2SvtH12o/iLXfGQr7DkKTdyRbbvrbkip54TJaGFGNgbMxP5Tm
OmiqYvNA99P1k0P+jIsM6TWftKcpUPZAB+WhXl1XURnlmP5yAczfb8A5140HRvG1
AXaeTJosXxRZg4uOP8ax+xch8mDqzs7bVDbwOYBEu4truiYDOZcVtElSIMOBHifr
G3jUF7uQfJ5npFfDTAhuH+l804F4Uba1d2bSzml8XPcHEsjnOqmIncyH3PvFn1AG
9rZMayQ1/JOCeQPKQP9tZacnlNHpsYXSn/1y+gnICRi0NCZUrUfWWl99unaO+oEZ
tA5szl/z1J1zRcgkjNwjYPJ91xuo5iBDHV5CoprrD6OoMUIwceO/HbuXJUA7mPiE
eFipt9nsXoO/J1bwajuzO8X1xRBi5OpM62U9QFQE4+Rr9GUrTk+gC+Bjm981GtcZ
8ywFbJrDU9h0uVoLxcq8soGO4/wu3roSKWoX5xD/UF7+pe+NW/VXI4Lzu/lJMylT
DhWWbc4tkZ1oOqGuhDSRfe6xXTTMMjw5Iph4UloZwYtB4yeJ/DTsCsPnGX9RVmeS
RIqzkjpA65sQVpxpHcDuNVeLkE5Sa75HGnKUNi62YkWYJ83wEa0kDGAphd/qlvGX
iuT/44L3A3x+z1hVCbka0r1UWmgIszynTNinh4FpyxQI3tUopoRLsJJiaL2NpLNN
zBA3F41kpxHivsD+FYEOyePQ3l5XecziGTvPwq/PQwt4PGJ34gjROposEvHxSyTY
4SGe+9NopkquE0xXbnvBcPx8dmiCiSoBZdqMWMvM7camUUDim2bTLJ+su5Hwv01X
tN/oMMNf3id7m1Ff1jgaYx8QBb2HXJAe81rjfwi5UmRr4vC2s1k6sJLA9F0xVUiO
3721jvzVMlQHlwHhvzhay07RG5qNCoidtcwJ0XCPPTvSuK/0uUqxF9/NkbiVNk//
Fwe1VibLPOpl5gwPnU2G9ViWU8WgvqY61v2Hc22fxujpfhnKMY4PUZti3eI3+r8g
RmZdldqPYuOsCukiP5qTKb8AI3IFP47tkgwEsSx32XIL8JeRXMNhBcgw/y68CgxM
ux+lozfRjiQ58aPTlv4x6Xilnos17+c8f0lMJbkEGhrwSja8Ftqzmh2otVpUAiKv
xt3B/YFv3S3rVHWT5MMn2kS34EzLVvWaP+LQVJDJp/Q+JvOgkhfhiPyUAWcZ5rVE
76Cw2uf0rqV/k1JiSbOhY3bq2WSTReML/IV75+CHjs+vMEHIYA2EYlHEq0GvpIAr
kU+96dnzRMFBAFCjMh66Wsx4Jf4CuiQHtXJlPfGNoaDDS08AtHV1HrjbwsGB0DiQ
TOPgT33vP1nhOzJvxugiUKUqyf21z0BDymveRlE4leU2WYR3/gbPSJGSG0oglcEU
tvYZ0eVAF3fWleKTCnNa0bqgODt0hMZihbuMFp5JXul5i8dZ2+THcMkF1e6efSv7
2mmt2DSaMZnalNCqNA1qD3+Zc2dycPtEh+J+Uti9+TULt2gLF2N16T27I0UnvQCw
g5np9+4BltjWA06VIcSHkx2Yczf50znij/WG5TWLv0sjPJ/qqdIxbTL4ngffmjf+
RjaFSjrZUnL5Q0im5V9tNAo8c2QMnRNQwi86GR/c623y+Y8HB8uVnIwAjFwx+IlS
yGhXqkp+mYY698STfn7eYeyMJVg1UOvnLyqWPsOz3HsVwcbaCImzWYjfoXC3gGUQ
6msmx8IypNcb2FXrJv8Q9/47NDUXZ11rltLKo6XyCwE1sPSPcO7e0xCKms1VRUQt
5sKyv7uF7CrBT491u4I60t1YdSEzwAXVeRRqGgzJJBFoYsTDaljTxiQJw/zmWpuy
xmPAsNdiWdP5lORW2hCrkShJWkuCiIKMkx+ntqiTt/HCQ5pe0FOE5bFB9uhKxY20
7qRgumz2twK8QRzWovnhbW9dIDTJn7BMfBE7UjozGCnQ+PejZUX2+TCpCkLlMvnu
qwaLThn8A2o4qmNoBdw9YgWumpo41b1YqdRFhs9ib8/9mWXptOCYZiYcbJmauNt6
TGsdkZBJdQ8JRKBLFscpOzUZ33eya8ZUKH5oyqDDleWRkdFiAo+xfGlBme98uZMn
YMOm96cozzImrwKI+GAc
=lYkl
-----END PGP SIGNATURE-----