[bt-devel] alternative GUI

[Jaak Ristioja]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Olaf!

On 21.07.2010 20:57, Olaf Radicke wrote:
> Pleas, lat me try develop a alternative GUI. The alternative GUI have oven
> namespace and don't touch the other code. The user have a choice. Only if
> start the programme with "--alter-gui" he behold the alternative GUI.

I reviewed your patch. Please understand that since your patch is in very early
development, we can't accept it in SVN. Personally I suggest, that you might want to clone
the git mirror of the SVN trunk from

  http://gitorious.org/bibletime

for your current development. That mirror is automatically updated every 20 minutes from
the sourceforge SVN repository.


I have the following remarks about the patch you sent us:

1) Conditional compilation. I think the alternative GUI should only be compiled if
explicitly enabled by specifying some arguments for the "cmake" command, e.g. "-D
BT_ALTERGUI".

2) Source code formatting issues:

  * Use m_ prefixes for class fields, so that we can use "m_fieldName"
    instead of "this->fieldName".

  * "// Intentionally empty" might be better a better comment than
    "// pass". Personally, I prefer just to inline such methods, and
    just type "{}" in the header files.

  * connect(m_backButton, SIGNAL(clicked()),
            this,         SLOT(doNothing())); // Good use of space

  * Use spaces instead of tabs, because tab size may vary for different
    tools/IDE's etc.

  * No newline at the end of C++ source files might result in a warning
    for some compilers.

  * No extra whitespace in source files after code on each line, empty
    lines have no whitespace. Extra whitespace confuses diff and other
    tools.

  * Please don't start identifiers with underscore, e.g. "_ix". Use
    more understandable camelCase names like "tabIndex". Types start
    with capital letter MyClass, identifiers have lowercase first letter.

  * Small spelling mistake: "menu", not "menue".

  * Don't indent classes/structs inside namespaces, only inside other
    classes, so we have more space to fit the code into the recommended
    80 character columns.

3) Use QCoreApplication::arguments().contains("--alter-gui") instead.

4) Use qDebug() << "and friends instead of iostream";

5) Use <QList> instead of <list>

6) Source code file names are in lowercase.

7) Only English in source code.


Happy hacking!
Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)

iQgcBAEBAgAGBQJMR03EAAoJEFqwhAoGc/hvN4tAAIAmlbID73jor/NAnoO5QIar
g5ovkL7je0rtj0qGftXNHdh5jY8yoKki1cKUR120VpCBGycFH5x6TicvHni/WwV8
8vLy3RUXzXEgCWViDXp9PG0PSViSaRQQFp1/Oe6k/91rpyr9NNUq4DzhluXtjiEC
97EAdggsc5WrToXJnVZTX1M+cV481hmqm8WqRQX2HZAdPF9ZqsCH0cFkQsiE6yXM
xMN48jWHhd647u86Br6rg4v/BDutPmSnNr3QxteXnDqxQX/MyMG6AasAV1kOwQTL
/h51QGXGsUCKbdcn2xCvgo2WOa40jZTpYY0rtbwAR1FOFFUrGmFGphI4ShE+NY+E
bku4WX3J9xEMxbNhsadTxdiq/zvTltQmXe52+kxxhHnrgZZF1Op/oeSoC+i5HIMx
6l3DeMBnNVDYEG5m87cze9zuKdxH8wt+py9xhl6F7YKEdf1lmoNjyjwKImNt6qkU
7MgY8ZHcNWnKluD2E8mBIDu9NaSCEFJueT2bQRZVpw6HXv5roIG/X/PPuDSSD2M2
60tUj8QxuzZIPTSo/MdBs+h2kOkUpplF9Uss5QvJ+7/cPM15lGjmU175t4NoIb2s
qCJz51q7c9dwSP1sqNxAC3FPx5swEZpTpFspsnD98BKG9h3plktgk5V3wfdY1yDB
H9P3lX3nPvvkS8L8Vddh5+grJKgiw9KmDTLKGUzkldXM3bJ4tU9mIxCdM0esYtMr
ZPq6ZPODKVqR1ji8Wrkz2tcSv5rg9oHAiKLjr+2yM1foVb6/5ijFqQfDtYerjnqD
oBSEa4CV82vmC75NFvGBQzUdKBgvjy4wcEInOa3B7j8nZ2xR+zYoPM44uAF6osWc
J778joHst4ItMtsJPW4jH+1N2H4rFKx9/Ra6/rwq+283hJYqoXyHM76sQjtXoMlj
E5w7KoSD7radK9RbrQ52uBusZSs7NVuqfRNi4vcGqBTKtjZtkHlvYCtBFesP4sLs
uzGAlo8HpH1UwWtyWSNrRjdhsqi3nvcFCBh2pam/K04Sos5k+epHzHDVQ0PuirQx
pD5kkfz2Ooira7i2F463xd59lKMuaYdHzJ1JS53/RyPHBbTMcKREMjTOntRF1x3W
8o4dyUKuhhlO9PI9mnMgwdm2oL6yvzr60y/lw3vWdReEPmyT/IL9ou1UuVDL8xOo
dzQWECIz0XnSnRdJTVTDigr0hp4VnPChtPugavGn6Ls65xFD+OLejm34Yd/KUT3s
XUke5a8JOAsS2mU5i/FX9OHpjb9WI0Fce3KniMyZ1SLZsq9M6CfavobK3yLchGWJ
MN6zMLTHKSEy4GxUnMPAY1v1Es/zOynTT3jhnaHrXWqEh8nkjpS+c5pxmBO8gEUY
NbIxPW25HeCjymuVu5IAoYg673+TjxRRYvtbSy9ZhTyIj5qCSbnsFXqWyvriUhfX
3ZdpL0v5Qul1KkP328lVuZQVoWNHnllSZfOrszbu0Ndpk9Xl136G/8aFld+Hlrmv
XraPnmRiIiszJmYbksRfX3SdvVGW/I+Hz4YcPXNMSGo9UPN44tWWJZ8L9v0rF/bX
Imvxf10TxRKYaEWlvLxt1wtKyrQBVOVYyBvt7wDa8niyIsQcZ3glbCoIfRK1cEAP
GRoX+LTbNLmZmVitUqGuc9jcb6wwji+AZaOACSUFKHTQcbbmsw6SlrCDCV3ELACr
YF9uC/eR//MOxVeXjP708uGVtob6P2EcQoCHmQKVfOLLcKbx9fmJYJmi2w3YMhMN
VTAoyEQB/0z6aZrMZF8uoYzcxM+TBhcP4/VuK6WCsA3vl9efQEoVy6WHslIjMOlJ
ch87jgr/cGv7X6HKCil7zjGHskyczZG6RCTpZezoglVc2m7df/azBQrJwgZJ9sMf
4UKrLcwD3iMPg+SDe0cFCLhFpuycABKuEBaFxnIBo1zteWMRAjXPhNYkyySThMWd
oKMYQEyXI4EnjDOGeoh+/k8hc3zoSq0+tz2uMqzszSSrmVZz5uMRAu49+WM1vU5w
hveneevwd3LEh2eVCgME7u+3FMlCXrngSDqVuDA8NhWX+2ByniDIHUmjn5Qqu/Sq
3+Ia/FTVjHwoBpsXEYdBSkYEUBz6SBB+oumvmezCbRqXql+a93nSSKjPVuNhNgnh
5BG9/icb1mpRSKylR8M8QcROKXNP6RqYUZq8Yoq0/+uFj0Nj+Qeo6ztfGT6ukqYs
kupvViZHWUiDIgYZFOmXRjX/gaPcTgi1RGvLf/VQ6w2qv+O74JB6CsGnAE2wE/7E
E6Nvcl2VCQbyZ2NmGt61iGsQWJORbXDcRMYW4zoaaDsC/S9e9EPfMVXCGU6XjwwZ
LKR5TNvuKVAagYZuBlAhoRyY8h933O1jMeQJoAKCDPQ6Bs9TS70FK1wEntPzZkJg
i8SyPKqfCIHWkBNeFsws6tOSbhelQcUhJZeCU9a7OKKTog4+SLWf6uOpxjcw337J
QspW5QCs+mm/UCunCyYEoLHLV5gDoA0rPb6am6hneu9xJ0+47Gfs30nssLo1V9QB
zGn794WS/A1rogTOZ1X4tlREY+CHTKQm8fMVndKvkCiYQwU/TbxgEy8o7rlpscZq
0vFFcWoRe0BJEKj6SvlMVWs0GtRO8OfxYcsomeQ82engGhiimeOOE+YFUBdUigd5
X6HCyxej9Rl3HpqurSi+UlgLzLyrJr8oYj6ghaZgYXfox8l+QZ//UtXBQ+0dWaNK
nq/PSu8rfhIigBbRoEaO
=31VC
-----END PGP SIGNATURE-----