[bt-devel] retranslateUi

[Jaak Ristioja]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 28.01.2010 14:18, Eeli Kaikkonen wrote:
> On Wed, 27 Jan 2010, Eeli Kaikkonen wrote:
>>> However, heres an extreme example of the theoretical opposite which we might likely
>>> reach in the future, on how this might be a problem: imagine a method initializing ten
>>> widgets in the following manner:
>>>
>>>    m_widget = new QSomeWidget(tr("Hello world!"), this);
>>>    m_widget->setSomeAttribute(someValue, someOtherValue);
>>>    m_widget->setWhatsThis(tr("Hello whatsthis readers!"));
>>
>> OK, that's a valid point. Please, all, comment on this. Does the
>> retranslateUi in every class make the code easier to read and write?
> 
> This is the question which the developers haven't yet answered, and yet
> it's more important to us than the translation UI issue. We need
> comments and opinions.

This is probably something Eeli and I disagree on. I think it is somewhat also a matter of
personal preference. For example for me all of the tr() strings in the middle of widget
initialization are a bit counterproductive. When I look at the code which creates new
widgets and puts them into place, and there is of lot of tr() going on, then "my vision
gets blurry and I see small ants instead of letters and code on the screen" :P

I don't know how much headache it will cause all of You if we had most of tr() calls (e.g.
with setText(), setWindowTitle(), setWhatsThis() etc) in retranslateUi() instead. But if
we were to archive that (retranslateUi() for all widgets), it would be relatively easy to
add dynamic translations.

To sum up: I think that retranslateUi() methods DO keep the code cleaner and easier to manage.

Jaak

PS: Since I've been doing a lot of refactoring, and will continue to do so, further issues
like this might emerge in the future. If I'm not mistaken, then the retranslateUi() issue
was brought up because of some refactoring I did on the BibleTime class (main window)
lately. The previous code just didn't look good (the QAction initialization method also
did everything else like initializing the toolbar and the main menu), therefore I needed
to break it up, hence I also implemented retranslateUi().
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)

iQgcBAEBAgAGBQJLYZMVAAoJEFqwhAoGc/hvELBAALK9+EVUY307+tozDCtBRe0v
TeWutAOxb+6q0ZfX+MNfDzBk/NcJnMS3N8brF5ceVRgenHEvP24K8/fvhh3O+UL7
73F41WRJXsIdhZV+endrvKb0etOC2xOlGN7iolVleOD2N+Qb21KMp5qV7er3howC
Rz48HQQTbE/pqX1Kpdq9ELEJvHQfmQPeVyvc1ddXlfRi7lhE7cd/xJRKqGZ0KMEJ
pvc/FXzi6LwNYLvbbIX1cZOChwxI0SkMJtMTApthEcNL9A+nAc9sVK2EuollvVwa
Svu6cFzPQnIU0H6eULMMX8DZYGJcKzL72llLC+gVZd/6582u6LiH6jJx0r4whmQb
fNnXUiLoWGVJY4KPg3RhYEuM3/77ULRZGhNKSGHuhbgIJt1w0xbQM1/r6+V2hnd9
UsXJH5/XPpLNwYyFcQxTAhgJ0g47GpWnwEYsplCzd5n9QAeaMrgJU63Mn1/UbJ1g
J58PhiGRRbGzBETWjmTydVePOnuU5qmQdzw5SZS4D2gM07T6IM/omPg6PQrM/usP
sWue2c4oNP73wG4Uv35zHZAlg4mJvkx1dbHvSy93Ilt/XBGnlnBayb0iD0FXXl5Y
v6nVu2WGKhSXANAwAbEfnzoi8YrIQon6rM4kI4Wl28A3lPgM7EsyMVyY3U+Rwh9t
s56S+eCkNJmrGXRgY12pKnFsNexF6H6ADiCxFVLnqaIxRQmK0zq72iU2FPShby1a
J/9a2Zm3mOHA9HLf2a29jgextewFz2eIGjBp8lYWfZZtaaoL9vo4BKtz0FL8dllX
2v3yYKzJZci8s3pQmr+tCRR4x0Q+rYQy3/v7dPAbJoqwdUz4XVbg0xeNV6b0xPCG
6IlonqoaixWB8pq/8sNf9aIfUNn5EJMHF9zAY9GM+OE3Gl0XnCyH7ro6LoO+IW6a
HEsyEAwMwPd3dFZvnk4lWpKUrGyzAo0QrL2fbDGqUpt07QCEZd3TCo5NvLDzudgu
w+inkDIi9JfpnzrfOWpVtPa1MYFYmaKoCZklkneqw0XkV6A2na5BXvi+kyZdQnzd
CGnewCFoKUkaPxRHXmw7e13QknJROoSb/gp8O2KR7Px8rqyq9elNOeRkrWGPCucS
qF9LG3VL1v5cGM8liyWGwGZvrTV/u/npCbbLYEBsI4lYRyhMmhTvVbxDfHetA7wt
t98GZ9xA2W5SMjYPIRWeI8wYx9oeQVjdfpgrPdL0Ydp89JH+ed118KYfxY5N0/OH
ZAw3+HhmcPW6FHxK40SV1GAYf/MbUJ21T3MmZV2U2VRXlnGU23lEAZjPWLzJMQSk
lGo9zwE3AGAz7LdHuaEJ6KRBiRllPriQoo/yXuP84Ev2fd36XwyhVqwlWfkgTVnH
w5RwQFP2vrhCKqmHP3s42fSYPI7Py5vipMEgtiUCUrYclUKQ4d3X/O7xoNJJQmd5
HNJCzHZb09Eu75TKnaC//4mEvNJp1ir0Mt6TBV9uxNxkj+i7N5sk0gRFWFT6egfz
qJHczst0LGvllnFCD1Ufh1k354tzFw6U6YpZuwcViLJw5yJkx9RPdeIqyb1oBJ6w
ALM96U2V1QcXxMkOM6frbfe842KYARJuFYTI5eozsuyP+l2nydq+dbIpwieiYVNY
Duzx4F8ZtNo5uuaKxjSL0Z5PeuCtjM7r/GF3e0BEk+XBCCAgmfHcVwJ2aU9FAEvA
x5FlPqIMKdAWudJM7crM8hM4freX/gr/eVUoWSRJtSmZruZL7Z/QCNPGv0Uo37fa
DKEC7vVTjoJkBYhY4uXqnErg1Qh7UWbpEahm9sDZu/EFgvcWdxXX6jSsDy2Ko5i+
2iiA9PhhBFv1BABIkZxK7delfpngA6WNPC4XAJlxwXqqQTqh1zrdJaL3XCuzusKG
bsxZNTfKEMJA4RHyKKHtur2ncZgM85lQHhX/cvBurX3F7l14/dTEb09r+PduJ5lm
9esHSYx0hRwZZ8Bs1CoRkX9ZnZKw2YaySrGG0xrfcGH9M0INb2yqksWIJvD6/bxs
IqkRxRQ6+OM8tda2xndaPnbGbx9ks5HvJSs32za9Abwq3YWTgTQEDXkT0OYRXxxk
12+nfcTSpWo2Xh8JCSVYcJ71wGKH6JzlBuv/8l6X/ZJ+96OLjmJ2jTtflS1XAqcA
7Cxh/75l3l9g8snZZdtEeuDWoXQGhaftpwjsuVjanOMebCKLmYqTLg2JxG3UO+Ky
Y8vaIXQ7TwvyA3l2Q4iJ53BXpbrYJmOfshiXnjffycR4qpODJ6CGHEfyTXV9KJrN
LNEhCkc22tg6lz++hw86uFuVUqPD5mctB5VlgP39DtOwHKjZaqE6KBp2AZc/bj40
CDtVfL2VnzqyE6CWdj/MHou8xvaoHaoPgN3w4xQpf9ZLiXWU74BuV96X4Sx7WTnC
2MdREX3jqeUjihmG5jrR0ibDF9tDHbT1cW/t4bNPoS0YN5zcZVW/GgJucJrNxSch
dEb0ePV5Irs6tBtKlTNDavqMgpDew1I+GTt6LwQpEWe0zEXAugRJXCEgbAfZJ721
6A9+NX8Bmzg6khBMJJ/fzb+5Lohm69a0b+3a/cKriLs79vmNdCV1ax/vWPBlAI9e
tYAEvmvwzvJGEuwO/NwdZff2KoqVgxjDYF/qyexhFDwZfXZ/uQUd7pFsOxPbAKW4
4C5doOHSapq7g9QqlQO9S2yDytsNHazR5UWYDGWB63I9l+zyZbZxvZXeH485QU9b
dug37pv6Hz7mbMbeHhbr
=yMA1
-----END PGP SIGNATURE-----