[bt-devel] Serious Bug

Jaak Ristioja Ristioja at gmail.com
Thu Feb 11 06:03:48 MST 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11.02.2010 14:32, Eeli Kaikkonen wrote:
> On Thu, 11 Feb 2010, Jaak Ristioja wrote:
>> On 11.02.2010 06:18, Gary Holmlund wrote:
>>> The ESV Bible does not have cross reference verses in it and the KJV
>>> does not properly show Strongs references in the MAG window. I have
>>> observed this on ubuntu 9.10 and Windows XP. I did some binary searching
>>> building various revisions and it looks like SVN2182 introduced the
>>> problem. I am not very familiar with the code in this revision. Can
>>> someone else look into this issue?
>>
>> First of all could you please be more specific what the problem is?
>>
>> SVN2182 is "CSwordBackend: Removed some unused methods and useless fields." by myself. As
>> far as I know, the commit should have no side effects other than boosting performance a
>> tiny bit.
> 
> Apparently you were wrong. I think the problem is that the backend
> inherits the SWORD class and implements some methods which are already
> implemented by the mother class. You didn't find the methods being used
> because you didn't look into the SWORD code, but the engine calls the
> methods and now uses the default implementations instead of ours.
> 
> This is a good warning and reminder: Premature optimization is the root
> of all evil.

You're so right! I wish there would have been a mention about this in the comment of our
reimplementation of that function. I will revert it ASAP.

Sorry for the inconvenience.

Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iQgcBAEBAgAGBQJLdAAvAAoJEFqwhAoGc/hvDuhAAK0AzOC8+E45Ge7xVCg3ou4N
xEFzxRoTMfvEeu+EbJwksAjXS7OYEr6i1kSTuG5Cgnhw4dEOstA1LB0PEeuWXipn
KJkYkXQHthd5Lvlgc2rhgyBXTavMjKIuOQVAfkQDzvJf0bXL8ys81EV4+YMWNX3+
5/HUQUYdeYDcMjDH6eNWrhYOvN5lFicihJUawylLiRsg0OODDkz0QQL3d4uAJ/YK
OwdTvsE4gVbVFILR0m2UKe66tGcYj6Q5UtFvT4zSc1h1ckWEaP6z8wn49m14mGos
4KoPDA5jpi4KlJjFroMgPNJz8yb4erGcki/Rx+hrbUcgWmOdcOIzTgO1NnfGHHzD
awcrYyqChpgkcB8+Ru45nzNYz6m+RwmeSocWVxoSWLRF9v3EfIoJAKB6DJSSkEC1
5VNb2n1bKm9HOPOV17V1rlrfZqz6Lpha8YbU5ZJ4EaIlMtLKxOicd5Aqk5DEz8JT
Yt6PTuUK37QE3dAr0gAMvpsxJbGmIE/h9zRkmGG1XJoo0L63P6bOFxZObyrLCYkQ
TKHizvPLO5CWHDFtsCZWE8lZmTz4dQ6ckhvQLm6bLO2hRDwscME/jwoDnhCzohn/
yj9ZbyoLIJqlHDmTLWVL6kTstsDhEawh43RvI7ieEIbTTDZjADHjr2jJf7rrPi91
/h6G5AzwtrYJIuXCV1nNxBdVJ8gO1TCnrMJOT5jMSuC/vl6YrGrnVOD4YyL1E5iJ
BBhS6Tvl9M0JnrSUUoevEmXVI2c+PkmciiSqR1r699wj6ydSLd0QBkXqEQtY6bCZ
CMZ1oSBGsRMPqvAcyVquAzu6FLtuX698Bv2yz+BleCWYECuU/1nx4ZeoTUJQi7VO
pznk91JfwTn6Lb6ZKe3unmLjy6O1RrVjJnVLchOLPLJkJstiLzgyDBNs1ifvzSv0
xgIaJOjgTBt/HGTfTrV4CQbCZPTaEPmSOmqexC2FqUO9No9+t4QjO8NueSgTDwsQ
1q0Q9YiQE1boU2B/cyGRwH7jhJe3mwW65GQAwfamfw1m60gUCAsym3csaShtICA0
WG/WfNB2iGux1ekfwJosAK/+lAS6v+cvJLRDSBxhNcxXgRU3E5Rd69jdMlXwIykf
A24tArTBgGJ1YfhVrECF8ju4amoC6ZX1MIvloieahHMtPx49vljqkzdiQ1LpPu8P
LEWBJf+kbKfRKlu12uLrz4mArnxEfiwqkUP0rQiKOisEbZSNGjSH2D7l2hRtd5wL
Lqyi0oHBUfGxWI2YXiNFjfHb40Of+CjTHDaCNzFm9xHbt/XH+zFnc/9ESxiYBSn+
00FdLqpS2XlsV4Jk3GPPRkL+ZsC+cBuP198WqDuCrgxb/OtLBIgQ2oHjGHeR2/35
2D3t6A2KsJzql/0r38o+UHLoXOxuZfxQFG3ZV3SAMxehSzkSxGokZNuIeXlUZ0+D
TsRZLTFezmvCwPuYKVT3dzCGFX8FfWdpNyHzA+FucaxK7VDDJDtBnM38ID6ql3w8
Unht8EdO2PNbZvJalG+QPmVQvEVi4294HlcGocIIRj4AK68Qi+Qn7mp0Hs/V9LEY
rM471HzqbEB8wEyXEp81loU2sGX5SEaFb0KnVf1CDCzRHcgq0hehxNgu3EzrCgWA
tU4cv1FSFjV6sK35nUVkSacLZ66Njy9G8lI8NNQXLFE+1G6xoQSaWn5UpLBZx8d1
Wl04WphnnQ1zsMN0MJStZ/AkZSqDk8OcICLHb94ICC4k6sTnC1NMncQKBFWsXQnl
tBcJofQTTJ6IcuhKkEleP0LUs11G9D/IsLS+ccFDnfEBUnd3AyAZoLarhO7oAkhr
jDhwVgCeesF4cDdjldnSrwVuRWV8jCBzjjbZf4ku0adp/WqPGgf+GGXQNKfCXX4d
eYyosDGJ8/xnXi8MqPzoj11Iem6ZPCh+iHBab7JQia/9KoC5AXTzfTRSOMX7cMSj
MhgYivT6+5T9B5hB571QobBTHRbIlMkXDNfSDlIbEJ7MqzONs9mec4UTkb1j34Ys
OTfeIu5bKXZzbVyLecP9ymB0rsSwm/X1+4mE8aceLqAuMDgdkWrbtHesL1XzXQbm
8AC/o+RGn85ULLA8sgyccWDYMlsH6q4TKnlh1Ti8qlqJc+Kz5c1U5yDDmzDs4GMH
eUlN0gxZ44gwN09R9HUA8VonusruiE3gVJe8q+XZamwuaMU2EvMIrY/sCK4ZWKqF
jyOR8r15i/TI7QwRCO0V213sx10DVXLZ3MbEggBO+fDeAuHroy2Ab9vQxy+98MW4
1MXblXPanpGt4Rn6t7PoBmuRS18vnOcIobFAZKml1esaHbaJzM2biZTMQbAe5yVk
RfNc0Ow4EdeHrI3s35klpRu7CRTbsKNi/01IUF2CuyanUf2Os/DsADFu1mzy6Q27
URA3AjQ6n6RZw3dAw8BJXdhQSX7LKHpLk5+igLNtida1v6lS7XSCD14YFjELivyK
jbdhfCp6ruOKBs9b3+XC2EsZd1+fo6n2H/UkgQfQr+WGBbocDWdeEU0Y94Zjwa01
ZbFL1/S9BMd4mMXnd3cWdGsFRVJO7FLCeDaqW8QpXAidg9Uv/tADtXq0A6OXLf5W
u/R2z3tOQG7xKDFkYtxKzuuA7io47IbasTcdmCVOqJLSUdyPjES5Pc2PK42DPAzC
SS7WY4NcsJ6zAF+aZihZxNlEAErQl/dRlH+IttW177pJIzg86NdQGvzNMWFedP2d
PwTElqbhiisUDCLMVpCg
=QiDj
-----END PGP SIGNATURE-----



More information about the bt-devel mailing list