[bt-devel] Problems with our OSIS handler (crashes with GerElb1905)

[Martin Gruner]

Hi Eeli,

I don't know. Maybe this was added to support a module that  had OSIS markup 
which wasn't yet standardized. Can you look in the OSIS specs please? If it 
does not allow for this case, remove it.

Thanks for investigating so far.

mg

On Thursday 26 March 2009 18:12:46 Eeli Kaikkonen wrote:
> >> Comment By: Eeli Kaikkonen (eelik)
> >
> > Date: 2009-03-26 16:41
> >
> > Message:
> > This seems to be a bug in the module. I'll try to change BT code so that
> > it doesn't crash, but it can't be displayed correctly. Xiphos displays
> > the footnote in v.5 like this:
> >
> > dh. überdeckte sie, ohne zu verdunkeln; denn es war eine lichte Wolke,
> > "die prachtvolle Herrlichkeit"(G2.)(Petr.)(1,)(17). Dasselbe Wort wird
> > von der Wolke gebraucht, welche die Stiftshütte bedeckte
> >
> > The OSIS token handled in BT code is:
> > w morph="robinson:G2. Petr. 1, 17"
>
> There is also problematic code in our handleToken.
>
> First, there is:
> if ((attrib = tag.getAttribute("lemma"))) {
> 	char splitChar = '|';
> 	const int countSplit1 = tag.getAttributePartCount("lemma", '|');
> 	const int countSplit2 =
> 		tag.getAttributePartCount("lemma", ' ');//TODO: not allowed, remove soon
>
> What is this "//TODO: not allowed, remove soon"? Apparently it has taken
> care of a space as multiple lemma (and also morph, which uses similar
> code) separator. But someone has known that it can't be used as a
> separator. If I take away the code related to spaces and leave only '|'
> there, it works and doesn't crash. So, can I do and commit it?
>
> There's another problem in line 200 where it originally crashed.
>
> const bool skipFirst =
> 	((val[0] == 'T') && ((val[1] == 'H') || (val[1] == 'H')));
>
> I don't know what T and H are, but at least it's obvious that
> 	(val[1] == 'H') || (val[1] == 'H')
> is not logical.
>
>
> --Eeli Kaikkonen
>
> _______________________________________________
> bt-devel mailing list
> bt-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/bt-devel