[bt-devel] problem in bible key chooser

[Martin Gruner]

Jaak,

please commit. Looks nice.
And I'd also ask for the buttons to be a little bigger.

WRT to the verse click behaviour bug, I do not think that this behaviour 
should be changed now. The current behaviour has been there for quite a while 
and users are happy with it (no reports at least). It seems that in the bug 
report the jump to verse 1 is wrong, this might be caused by broken locales or 
something. We need to ask for the console error log. This could be fixed, but 
the general mechanism we have in place is ok. Imo.

I think we'll rework the display logic in future, based on much more 
javascript (jquery), but that will take some time. Then much more will happen 
without a page reload than currently.

mg

Am Samstag, 15. August 2009 17:37:09 schrieb Jaak Ristioja:
> Gary Holmlund wrote:
> > Jaak Ristioja wrote:
> >> Here is version 3 of that patch, which makes sure that the verse is
> >> always entirely shown in the line edit.
> >>
> >> Jaak
> >
> > Version 3 does not have the problem I was concerned about. It seems to
> > work quite well.
> >
> > I have one suggestion. With kde the buttons are smaller in height than
> > when using gnome. They are almost to short. Since the buttons are not
> > limited by fitting in the toolbar, perhaps they could be a little taller.
> >
> > It would be good to hear comments from Eeli or Martin.
> >
> > Gary
>
> Regarding their height, I think thats just a matter of changing "const
> unsigned int ARROW_HEIGHT = 12;" in
> src/frontend/keychooser/versekeychooser/btdropdownchooserbutton.cpp.
>
> In case it works well, I just need a green light from our release
> manager to commit it to trunk, or we need to branch. :)
>
> Jaak
>
> _______________________________________________
> bt-devel mailing list
> bt-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/bt-devel