[bt-devel] Eliminate KFontChooser from Configuration Dialog

Gary Holmlund gary.holmlund at gmail.com
Mon Nov 10 19:09:24 MST 2008


Eeli Kaikkonen wrote:
> The code looks good. Some words about style: personally I prefer
>
> void Class::method()
> {
> }
>   
Good. I like this also. I had been trying to conform to the style
that I had seen in use.
> I would like to see some improvements with layout. The current one is 
> good but sizes are not so good. The font size chooser area should be 
> narrow. Actually the whole config dialog should be smaller. Fashionable 
> mini-laptops have small displays and all dialogs should fit in 800x600 
> or even 800x480 minus desktop panel and window decorations (Asus Eeepc 
> 701). The BibleTime main window is good but the config dialog is way too 
> big, and I think it's because of the Languages page. Restructuring the 
> whole dialog may be necessary and it's needed anyways as I wrote earlier 
> but all parts should be resizeable anyways.
>
> I don't know if the header "Requested Font" is necessary. The widget is 
> self-explaining for anyone who has used programs which handle text. 
> "Font", "Font style" and "Size" are nice though. "Font" doesn't sound 
> correct, actually it means family+style+size or family+style (see 
> wikipedia article for font). Qt API uses "family". OpenOffice uses "Font 
> Name" in tooltip. I know the KDE class uses "Font" but it doesn't make 
> it correct.
>   
I will look into layout changes. My goal had been replacing the KDE
with minimal change in looks. I agree it needs to be smaller.
> If you want to move to a next target it could be 
> http://devel.bibletime.info/wiki/BibleTime1Refactoring#Commentary_editor_font_chooser. 
> After that the Search analysis view needs work, it's half done. Or do 
> you have something else in mind? You are already a bit more familiar 
> with the code and the application and can maybe propose something.
>
> --Eeli Kaikkonen
>   
I will start looking at these.

Gary



More information about the bt-devel mailing list