[bt-devel] [ bibletime-Bugs-1668060 ] display templates: probs with centered vertical verse align

Tue May 20 09:16:12 MST 2008

Bugs item #1668060, was opened at 2007-02-24 22:57
Message generated for change (Comment added) made by mgruner
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100954&aid=1668060&group_id=954

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Frontend / Bible display window
Group: in progress
>Status: Closed
>Resolution: Fixed
Priority: 2
Private: No
Submitted By: Matthias (mattthew)
>Assigned to: Martin Gruner (mgruner)
Summary: display templates: probs with centered vertical verse align

Initial Comment:
In the parallel view of multiple bibles, jumping to a verse via the key chooser or by clicking a verse number will scroll to the corresponding HTML anchor. However, this anchor refers to the start of the paragraph of the leftmost bible column, but the text in other bible columns might start earlier as it might be longer for this verse and the current verse is vertically centered in some display templates. Which means that one has to scrll somewhat up manually to see all verse text in all translations.

This problem is found in the display templates Crazy, Green and Standard, but not in Simple and High Contrast which use top vertical alignment of tables verses.

I would suggest to use top vertical aligment of the current verse in all display templates. The non-current verses might be vertically centered if desired by design;  in the Standard display template it is the other way round now.

I'm using BT 1.6.3b .. which is the best BT since its start :)

----------------------------------------------------------------------

>Comment By: Martin Gruner (mgruner)
Date: 2008-05-20 18:16

Message:
Logged In: YES 
user_id=169722
Originator: NO

Fixed in SVN. In the table, now vertical-align:top; is used. Will be in
1.7.

----------------------------------------------------------------------

Comment By: Eeli Kaikkonen (eelik)
Date: 2008-05-17 11:34

Message:
Logged In: YES 
user_id=1031029
Originator: NO

See also
https://sourceforge.net/tracker/index.php?func=detail&aid=1745247&group_id=954&atid=100954

I would finally like to resolve and close these. The abovementioned bug
affects the new NASB module, too. It would be bad if one of the most
popular modules and one important commercial module would be continuously
affected by this kind of irritating bug.

I suggest that we change the css code (modified example from the Blue
template):

/* Settings which apply to all entries in all modules */
.entry {
	padding: 2px;
/* no align is needed at all*/
 	/*vertical-align: middle;*/
	/*vertical-align: top;*/
	text-align: justify;
}
td.entry {
	vertical-align: top;
	text-align: justify !important;
}

/* Keep the values the same as in .entry (take the border into account!)
*/
.currententry {
	padding: 2px;
/*not really needed IMO*/
 	/*vertical-align: middle;*/
	text-align: justify;
	background-color: #E6E4FF;
}
/* NEW: current entry is aligned just as any other entry in parallel
mode*/
td.currententry {
	vertical-align: top;
	text-align: justify !important;
}

----------------------------------------------------------------------

Comment By: Martin Gruner (mgruner)
Date: 2008-05-17 11:20

Message:
Logged In: YES 
user_id=169722
Originator: NO

thedeveloper, what's the status here? What do you suggest?

----------------------------------------------------------------------

Comment By: Dave (thedeveloper)
Date: 2007-05-07 07:01

Message:
Logged In: YES 
user_id=477761
Originator: NO

Ok. I've got this committed but I'm not going to close this yet. We still
have the problem of the left most column having a section title at the
first of it which gets included in the table row. The anchor is not
actually the first letter of the paragraph in the left most column but the
verse number, i.e. the entry name. We need to fix it for that case as well,
and I'm not sure of CSS wizardy is the way to go there.

----------------------------------------------------------------------

Comment By: Martin Gruner (mgruner)
Date: 2007-04-19 08:12

Message:
Logged In: YES 
user_id=169722
Originator: NO

thedeveloper: ?

----------------------------------------------------------------------

Comment By: Dave (thedeveloper)
Date: 2007-03-22 02:03

Message:
Logged In: YES 
user_id=477761
Originator: NO

One issue that is run into is that some bible versions use section titles
as a part of the entry for the verse. So this will occur even with
vertical-align: top. I suspect that part of this problem is CSS related but
part of it is anchor placement related. But I am still working on a fix

----------------------------------------------------------------------

Comment By: Martin Gruner (mgruner)
Date: 2007-03-21 08:27

Message:
Logged In: YES 
user_id=169722
Originator: NO

Hi David, please put the fixes in soon if you can. The next version is
approaching.

----------------------------------------------------------------------

Comment By: Dave (thedeveloper)
Date: 2007-02-25 00:56

Message:
Logged In: YES 
user_id=477761
Originator: NO

I believe I was experimenting with some things and found a way to fix
this. I've got some other fixes to go into the templates as well so I'll be
posting them into cvs soon.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100954&aid=1668060&group_id=954