[bt-devel] [ bibletime-Bugs-1828355 ] ESV module OSIS support

[SourceForge.net]

Bugs item #1828355, was opened at 2007-11-08 15:40
Message generated for change (Comment added) made by eelik
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100954&aid=1828355&group_id=954

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Eeli Kaikkonen (eelik)
Assigned to: Nobody/Anonymous (nobody)
Summary: ESV module OSIS support

Initial Comment:
As was pointed out by someone else the display support for ESV is not very good. Here is the OSIS text from Gen1:6:

And God said, <note n="d" osisID="Gen.1.6!crossReference.d" osisRef="Gen.1.6" swordFootnote="1" type="crossReference"><reference osisRef="Job.37.18">Job 37:18</reference>; <reference osisRef="Ps.136.5">Ps. 136:5</reference>; <reference osisRef="Jer.10.12">Jer. 10:12</reference>; <reference osisRef="Jer.51.15">51:15</reference></note><q level="1" marker="“" sID="01001006.1"/>Let there be an expanse<note n="1" osisID="Gen.1.6!note.1" osisRef="Gen.1.6" swordFootnote="2" type="alternative">Or <hi type="italic"><catchWord>a</catchWord> canopy</hi>; also verses 7, 8, 14, 15, 17, 20</note> in the midst of the waters, and let it separate the waters from the waters.<q eID="01001006.1" level="1" marker="”"/><milestone type="line"/>

Our HTML display doesn't understand the second note. I don't know if it's good Sword OSIS, it's so complicated. But something should be done.

----------------------------------------------------------------------

>Comment By: Eeli Kaikkonen (eelik)
Date: 2008-05-17 07:49

Message:
Logged In: YES 
user_id=1031029
Originator: YES

The ESV module gives number 1 to first note of each verse, therefore there
are several (1) notes. If there are more notes in one verse they are
numbered 1, 2...

This means that the fix which I gave works correctly. I suggest that this
will be applied. I'm not going to do it without confirmation that it
doesn't break anything. I don't know the code or the purpose of the
"alternative" well enough to be sure.

----------------------------------------------------------------------

Comment By: Eeli Kaikkonen (eelik)
Date: 2008-05-16 16:33

Message:
Logged In: YES 
user_id=1031029
Originator: YES

In bt_osishtml.cpp line 225 starts handling of "note" tag. The bug is
somewhere between the lines 276 and 316 where the "type" attribute is
handled. The type "alternative" is found in this specific case. I'm not
sure what the real problem is but "alternative" should be handled in the
same way than an ordinary note. Now the alternative text is added to the
buffer and the tags inside it are ignored with their text. The final HTML
is:

 Let there be an expanse<span class="italic"></span> <span
class="alternative" alternative="; also verses 7, 8, 14, 15, 17, 20"
title="Alternative text"></span> in the midst of the waters

Probably the wanted HTML code is:

<span class="footnote" note="ESV/Gen 1:6/1">1</span>

and the alternative text is meant to be get later. Commenting out the
sections which handle the "alternative" gives almost the wanted result. The
only problem is that all the footnotes in Genesis 1 have number 1.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100954&aid=1828355&group_id=954