[bt-devel] Some patches

[Joachim Ansorg]

Hi,
I suggest that we'll give you write access to cvs :)

What is your SourceForge user name? That way you can more easily fix the 
things which are not working.
Basic search highlighting using lucene syntax would be helpful. But don't take 
a lot of time to do it, it's not that important IMHO that it works in all 
details.

Joachim

> csearchdialog.cpp
>
> I installed an update for my SuSE 10.0.  Now the button for Yes to index
> returns 259 which is the logical or of Yes and Default.
>
> in function startSearch()
> approx line 116
>
> if ((result == (QMessageBox::Yes | QMessageBox::Default)) || (result ==
> QMessageBox::Yes) || (result == QMessageBox::Default) ) {
>
>
>
>
> csearchdialogpages.cpp
>
> I found that the Strong's numbers were being matched to shorter numbers.
> Like H012 would match H012X and H012XX.
>
> in function getStrongsNumberText()
> approx line 119
>        // REPLACE-> if (sNumber.find(lemmaText) >= 0) {
>        if (sNumber == lemmaText) {
>
> in function highlightSearchedText()
> approx line 280
>           // REPLACE-> if (lemmaText.find(sNumber) >= 0) {
>           if (sNumber == lemmaText) {
>
>
>
> Next I found that words like AND and OR were being highlighted when AND and
> OR are operators to the search function.
>
> in the function highlightSearchedText()
> approx line 310
> 	QStringList words = QStringList::split(" ", searchedText);
> 	for ( int wi = 0; (unsigned int)wi < words.count(); ++wi ) {
> 		QString word = words[ wi ];
> -> ADD		if ((word == "AND") || (word == "OR"))
> -> ADD			continue;
>
>
> There are a few other things broken with the highlightSearchedText.
> 	1) "quoted strings" are not treated as a single token.
> 	2) small words are highlighted within big words.
>
> Would you like me to take a stab at fixing these?
>
> Thanks
> Jim
> _______________________________________________
> bt-devel mailing list
> bt-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/bt-devel