[bt-devel] [ bibletime-Bugs-1458848 ] Search results multiple times per verse

[SourceForge.net]

Bugs item #1458848, was opened at 2006-03-26 17:47
Message generated for change (Comment added) made by jim-campbell
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100954&aid=1458848&group_id=954

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Frontend / Search dialog
Group: in progress
Status: Open
>Resolution: Fixed
Priority: 8
Submitted By: Joachim Ansorg (joachim)
Assigned to: Jim Campbell (jim-campbell)
Summary: Search results multiple times per verse

Initial Comment:
Searching for strongs strong:H0430 in the KJV 2003
module gives two times a result if ther's two times a
hit for a verse.

----------------------------------------------------------------------

>Comment By: Jim Campbell (jim-campbell)
Date: 2006-04-06 15:00

Message:
Logged In: YES 
user_id=689979

Added fix to cvs - 2006-04-06.

----------------------------------------------------------------------

Comment By: Jim Campbell (jim-campbell)
Date: 2006-03-31 15:51

Message:
Logged In: YES 
user_id=689979

If I understand the problem correctly the fix is quite simple.

we just need to add a check before adding the verse to the
keyNameList.

if (keyNameList.findIndex (keyName) == -1)


csearchdialogpages.h  approx line 81

   void addKeyName(const QString& keyName) {
       if (keyNameList.findIndex (keyName) == -1)
           keyNameList.append(keyName);
   }


----------------------------------------------------------------------

Comment By: Jim Campbell (jim-campbell)
Date: 2006-03-30 15:15

Message:
Logged In: YES 
user_id=689979

Yes, I will look into this.

----------------------------------------------------------------------

Comment By: Martin Gruner (mgruner)
Date: 2006-03-30 09:27

Message:
Logged In: YES 
user_id=169722

Joachim, after looking closer, I do not see what you mean. Can you please give specific examples that I can test to see this bug?

mg

----------------------------------------------------------------------

Comment By: Martin Gruner (mgruner)
Date: 2006-03-26 18:51

Message:
Logged In: YES 
user_id=169722

Hey Jim. This is a serious issue and could have to do with the Strong's result parsing. Could you please look at it? Thanks.
mg

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100954&aid=1458848&group_id=954