PMD 4.2.5 Report
2010-08-28 - 00:01:05

Summary

FilesTotalPriority 1Priority 2Priority 3Priority 4Priority 5
60109
16
6
76
11
0

org.crosswire.bibledesktop.display.basic.URITipHelper

PrioLineMethodDescription
3
retrieve Avoid using if statements without curly braces
3
retrieve Avoid using if statements without curly braces
3
retrieve Avoid using if statements without curly braces
3
retrieve Avoid using if statements without curly braces
3
retrieve Avoid printStackTrace(); use a logger call instead.
3
getTipTitle Avoid using if statements without curly braces
3
enterURI Avoid using if statements without curly braces
3
leaveURI Avoid using if statements without curly braces
3
interested Avoid using if statements without curly braces
3
interested Avoid using if statements without curly braces
3
interested Avoid using if statements without curly braces
3
interested Avoid using if statements without curly braces
Total number of violations for this class: 12

org.crosswire.bibledesktop.display.basic.ActiveURITip

PrioLineMethodDescription
3
updateText Avoid using if statements without curly braces
3
updateText Avoid printStackTrace(); use a logger call instead.
3
showTip Avoid using if...else statements without curly braces
3
showTip Avoid using if...else statements without curly braces
3
showTip Avoid using if...else statements without curly braces
3
showTip Avoid using if...else statements without curly braces
3
hideTip Avoid using if statements without curly braces
3
interested Avoid using if statements without curly braces
3
interested Avoid using if statements without curly braces
3
interested Avoid using if statements without curly braces
3
interested Avoid using if statements without curly braces
Total number of violations for this class: 11

org.crosswire.bibledesktop.display.basic.URITipMgr

PrioLineMethodDescription
3
setDelay Avoid using if statements without curly braces
3
updateText Avoid using if statements without curly braces
3
updateText Avoid printStackTrace(); use a logger call instead.
3
showTip Avoid using if...else statements without curly braces
3
showTip Avoid using if...else statements without curly braces
3
showTip Avoid using if...else statements without curly braces
3
showTip Avoid using if...else statements without curly braces
3
enterURI Avoid using if...else statements without curly braces
Total number of violations for this class: 8

org.crosswire.jsword.bridge.BookInstaller

PrioLineMethodDescription
3
main Avoid printStackTrace(); use a logger call instead.
3
main Avoid printStackTrace(); use a logger call instead.
3
main Avoid printStackTrace(); use a logger call instead.
3
main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 4

org.crosswire.bibledesktop.display.basic.LazyHTMLEditorKit

PrioLineMethodDescription
3
install Avoid using for statements without curly braces
3
install Avoid using if...else statements without curly braces
3
install Avoid using if...else statements without curly braces
Total number of violations for this class: 3

org.crosswire.common.swing.ActionFactory

PrioLineMethodDescription
3
buildActionMap Avoid empty catch blocks
3
getActionString Avoid empty catch blocks
3
getActionString Avoid empty catch blocks
Total number of violations for this class: 3

org.crosswire.common.util.Logger

PrioLineMethodDescription
3
doLogging This statement may have some unnecessary parentheses
2
 Use of modifier volatile is not recommended.
2
 Use of modifier volatile is not recommended.
Total number of violations for this class: 3

org.crosswire.jsword.examples.APIExamples

PrioLineMethodDescription
3
installBook Avoid printStackTrace(); use a logger call instead.
3
installBook Avoid printStackTrace(); use a logger call instead.
3
installBook Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 3

org.crosswire.bibledesktop.desktop.XSLTProperty

PrioLineMethodDescription
4
 A getX() method which returns a boolean should be named isX()
4
 A getX() method which returns a boolean should be named isX()
Total number of violations for this class: 2

org.crosswire.common.swing.NudgeButton

PrioLineMethodDescription
4
 A getX() method which returns a boolean should be named isX()
4
 A getX() method which returns a boolean should be named isX()
Total number of violations for this class: 2

org.crosswire.common.diff.Commonality

PrioLineMethodDescription
1
 A class which only has private constructors should be final
3
halfMatch Avoid assignments in operands
Total number of violations for this class: 2

org.crosswire.common.diff.DiffCleanup

PrioLineMethodDescription
3
cleanupSemantic Avoid empty while statements
3
cleanupEfficiency Avoid empty while statements
Total number of violations for this class: 2

org.crosswire.common.icu.DateFormatter

PrioLineMethodDescription
1
 A class which only has private constructors should be final
3
parse An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type.
Total number of violations for this class: 2

org.crosswire.common.util.NetUtil

PrioLineMethodDescription
3
makeDirectory These nested if statements could be combined
3
getAsFile Do not add empty strings
Total number of violations for this class: 2

org.crosswire.common.xml.XMLFeature

PrioLineMethodDescription
1
 A class which only has private constructors should be final
4
 A getX() method which returns a boolean should be named isX()
Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookIndexer

PrioLineMethodDescription
3
main Avoid printStackTrace(); use a logger call instead.
3
main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookLookup

PrioLineMethodDescription
3
main Avoid printStackTrace(); use a logger call instead.
3
main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 2

org.crosswire.jsword.index.lucene.analysis.AnalyzerFactory

PrioLineMethodDescription
4
 A getX() method which returns a boolean should be named isX()
4
 A getX() method which returns a boolean should be named isX()
Total number of violations for this class: 2

org.crosswire.bibledesktop.book.BibleComboBoxModel

PrioLineMethodDescription
1
getElementAt A switch with less than 3 branches is inefficient, use a if statement instead.
Total number of violations for this class: 1

org.crosswire.bibledesktop.book.install.BookFont

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.bibledesktop.book.install.BookIcon

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.bibledesktop.display.basic.TabbedBookDataDisplay

PrioLineMethodDescription
3
getBooks Returning 'books' may expose an internal array.
Total number of violations for this class: 1

org.crosswire.bibledesktop.display.basic.TextPaneBookDataDisplay

PrioLineMethodDescription
3
setBookData The user-supplied array 'books' is stored directly.
Total number of violations for this class: 1

org.crosswire.bibledesktop.passage.KeyTreeNode

PrioLineMethodDescription
4
 A getX() method which returns a boolean should be named isX()
Total number of violations for this class: 1

org.crosswire.bibledesktop.passage.WholeBibleTreeNode

PrioLineMethodDescription
4
 A getX() method which returns a boolean should be named isX()
Total number of violations for this class: 1

org.crosswire.common.progress.swing.JobsProgressBar

PrioLineMethodDescription
3
createCancelButton Consider simply returning the value vs storing it in local variable 'cancelButton'
Total number of violations for this class: 1

org.crosswire.common.swing.CWOptionPane

PrioLineMethodDescription
3
styleFromMessageType A switch statement does not contain a break
Total number of violations for this class: 1

org.crosswire.common.swing.desktop.LayoutPersistence

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.common.config.AbstractReflectedChoice

PrioLineMethodDescription
3
setString Avoid catching NullPointerException; consider removing the cause of the NPE.
Total number of violations for this class: 1

org.crosswire.common.diff.Distance

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.common.history.History

PrioLineMethodDescription
2
visit Avoid instantiating Long objects.Call Long.valueOf() instead
Total number of violations for this class: 1

org.crosswire.common.util.CWClassLoader

PrioLineMethodDescription
3
adjustPackageSearch Prefer StringBuffer over += for concatenating strings
Total number of violations for this class: 1

org.crosswire.common.util.CallContext

PrioLineMethodDescription
2
 Use of modifier volatile is not recommended.
Total number of violations for this class: 1

org.crosswire.common.util.Convert

PrioLineMethodDescription
3
string2Boolean Position literals first in String comparisons
Total number of violations for this class: 1

org.crosswire.common.util.Countries

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.common.util.IOUtil

PrioLineMethodDescription
3
unpackZip These nested if statements could be combined
Total number of violations for this class: 1

org.crosswire.common.util.Languages

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.common.util.LucidException

PrioLineMethodDescription
3
 The user-supplied array 'params' is stored directly.
Total number of violations for this class: 1

org.crosswire.common.util.PatternFormatter

PrioLineMethodDescription
2
format Avoid instantiating Long objects.Call Long.valueOf() instead
Total number of violations for this class: 1

org.crosswire.common.util.StringUtil

PrioLineMethodDescription
3
toString Avoid appending characters as strings in StringBuffer.append.
Total number of violations for this class: 1

org.crosswire.common.util.Translations

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.common.xml.SerializingContentHandler

PrioLineMethodDescription
3
 StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).
Total number of violations for this class: 1

org.crosswire.common.xml.XalanProcess

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.jsword.view.web.DownloadSet

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.jsword.view.web.Msg

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.jsword.book.BookData

PrioLineMethodDescription
3
getBooks Returning 'books' may expose an internal array.
Total number of violations for this class: 1

org.crosswire.jsword.book.OSISUtil

PrioLineMethodDescription
3
rtfToOsis This call to String.startsWith can be rewritten using String.charAt(0)
Total number of violations for this class: 1

org.crosswire.jsword.book.filter.FilterFactory

PrioLineMethodDescription
2
 Use of modifier volatile is not recommended.
Total number of violations for this class: 1

org.crosswire.jsword.book.readings.ReadingsBookDriver

PrioLineMethodDescription
3
getBooks Returning 'books' may expose an internal array.
Total number of violations for this class: 1

org.crosswire.jsword.book.sword.ConfigEntryTable

PrioLineMethodDescription
3
loadContents Prefer StringBuffer over += for concatenating strings
Total number of violations for this class: 1

org.crosswire.jsword.book.sword.RawFileBackend

PrioLineMethodDescription
3
createDataTextFile Prefer StringBuffer over += for concatenating strings
Total number of violations for this class: 1

org.crosswire.jsword.book.sword.RawLDBackend

PrioLineMethodDescription
3
get Avoid empty catch blocks
Total number of violations for this class: 1

org.crosswire.jsword.bridge.BookExporter

PrioLineMethodDescription
3
main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 1

org.crosswire.jsword.bridge.DwrBridge

PrioLineMethodDescription
3
getOSISString Avoid empty catch blocks
Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.IndexMetadata

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.LuceneIndex

PrioLineMethodDescription
3
 These nested if statements could be combined
Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.analysis.AbstractBookAnalyzer

PrioLineMethodDescription
4
 A getX() method which returns a boolean should be named isX()
Total number of violations for this class: 1

org.crosswire.jsword.passage.AbstractKeyList

PrioLineMethodDescription
3
 StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).
Total number of violations for this class: 1

org.crosswire.jsword.passage.PassageUtil

PrioLineMethodDescription
4
 A getX() method which returns a boolean should be named isX()
Total number of violations for this class: 1

org.crosswire.jsword.util.WebWarning

PrioLineMethodDescription
1
 A class which only has private constructors should be final
Total number of violations for this class: 1

Generated by PMD 4.2.5 on 2010-08-28 - 00:01:05.