PMD 5.1.3 Report

2016-03-25 - 07:32:10

Summary

Files	Total	Priority 1	Priority 2	Priority 3	Priority 4	Priority 5
85	213	2	5	206	0	0

org.crosswire.jsword.book.Defaults

Prio	Begin Line	Method	Description
3	97	unsetBible	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	136	unsetCommentary	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	175	unsetDictionary	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	214	unsetDailyDevotional	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	253	unsetGreekDefinitions	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	292	unsetHebrewDefinitions	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	331	unsetGreekParse	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	370	unsetHebrewParse	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	400	getDefaultBible	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	407	getDefaultCommentary	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	414	getDefaultDictionary	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	421	getDefaultDailyDevotional	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	428	getDefaultGreekDefinitions	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	435	getDefaultHebrewDefinitions	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	442	getDefaultGreekParse	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	449	getDefaultHebrewParse	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	494	checkAllPreferable	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	506	checkPreferable	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.

Total number of violations for this class: 18

org.crosswire.jsword.book.sword.SwordUtil

Prio	Begin Line	Method	Description
3	60	readRAF	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	76	readNextRAF	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	120	writeRAF	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	125	writeNextRAF	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	145	readUntilRAF	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	161	readUntilRAF	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	219	encodeLittleEndian32	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	235	decodeLittleEndian16	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	253	encodeLittleEndian16	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	267	findByte	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	282	findByte	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.

Total number of violations for this class: 11

org.crosswire.common.xml.HTMLSerializingContentHandler

Prio	Begin Line	Method	Description
3	69	decorateTagName	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	70	decorateTagName	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	84	decorateAttributeName	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	85	decorateAttributeName	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	99	decorateAttributeValue	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	100	decorateAttributeValue	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	115	decorateCharacters	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	116	decorateCharacters	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	131	decorateIndent	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	132	decorateIndent	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 10

org.crosswire.jsword.book.sword.RawLDBackend

Prio	Begin Line	Method	Description
3	145	get	Avoid empty catch blocks
3	148	get	Avoid empty catch blocks
3	186	getRawTextLength	A switch statement does not contain a break
3	219	getIndex	A switch statement does not contain a break
3	461	external2internal	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	567	dumpIdxRaf	Avoid printStackTrace(); use a logger call instead.
3	570	dumpIdxRaf	Avoid printStackTrace(); use a logger call instead.
3	599	toIMP	Avoid appending characters as strings in StringBuffer.append.
3	606	toIMP	Avoid printStackTrace(); use a logger call instead.
3	609	toIMP	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 10

org.crosswire.common.diff.CommonMiddle

Prio	Begin Line	Method	Description
3	96	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	97	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	98	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	99	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	100	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	101	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	102	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	103	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 8

org.crosswire.jsword.book.install.sword.AbstractSwordInstaller

Prio	Begin Line	Method	Description
3	104	getInstallerDefinition	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	105	getInstallerDefinition	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	106	getInstallerDefinition	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	107	getInstallerDefinition	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	108	getInstallerDefinition	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	109	getInstallerDefinition	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	337	reloadBookList	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 7

org.crosswire.jsword.index.lucene.LuceneQueryDecorator

Prio	Begin Line	Method	Description
3	43	decorateAllWords	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	70	decoratePhrase	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	71	decoratePhrase	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	86	decorateNotWords	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	100	decorateRange	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	101	decorateRange	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	102	decorateRange	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 7

org.crosswire.jsword.passage.Verse

Prio	Begin Line	Method	Description
3	236	getVerseIdentifier	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	237	getVerseIdentifier	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	238	getVerseIdentifier	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	239	getVerseIdentifier	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	245	clone	clone() method should be implemented only if implementing Cloneable interface
3	439	parseInt	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.

Total number of violations for this class: 6

org.crosswire.common.diff.PatchEntry

Prio	Begin Line	Method	Description
3	153	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	154	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	155	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	156	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	379	encode	A switch statement does not contain a break

Total number of violations for this class: 5

org.crosswire.common.xml.XMLUtil

Prio	Begin Line	Method	Description
3	136	escape	A switch statement does not contain a break
3	276	recloseTags	Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
3	279	recloseTags	Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
3	282	recloseTags	Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
3	310	recloseTags	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 5

org.crosswire.jsword.passage.VerseRange

Prio	Begin Line	Method	Description
3	260	getOsisRef	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	261	getOsisRef	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	269	getOsisRef	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	270	getOsisRef	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	344	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 5

org.crosswire.jsword.book.sword.SwordBookMetaData

Prio	Begin Line	Method	Description
3	459	normalize	Prefer StringBuffer over += for concatenating strings
3	553	hasFeature	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	980	adjustHistory	Prefer StringBuffer over += for concatenating strings
3	992	report	These nested if statements could be combined

Total number of violations for this class: 4

org.crosswire.jsword.book.sword.ZVerseBackend

Prio	Begin Line	Method	Description
3	379	dumpIdxRaf	Avoid printStackTrace(); use a logger call instead.
3	391	dumpIdxRaf	Avoid printStackTrace(); use a logger call instead.
3	429	dumpCompRaf	Avoid printStackTrace(); use a logger call instead.
3	441	dumpCompRaf	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 4

org.crosswire.jsword.bridge.BookInstaller

Prio	Begin Line	Method	Description
3	288	main	Avoid printStackTrace(); use a logger call instead.
3	316	main	Avoid printStackTrace(); use a logger call instead.
3	331	main	Avoid printStackTrace(); use a logger call instead.
3	333	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 4

org.crosswire.jsword.book.BookData

Prio	Begin Line	Method	Description
3	163	getBooks	Returning 'books' may expose an internal array.
3	416	keyIteratorContentByVerse	Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
3	458	addHeaderAndSetShowDiffsState	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 3

org.crosswire.jsword.book.OSISUtil

Prio	Begin Line	Method	Description
3	909	isCanonical	Avoid unused private methods such as 'isCanonical(Content)'.
3	1129	rtfToOsis	This call to String.startsWith can be rewritten using String.charAt(0)
3	1218	recurseElement	Avoid unused private methods such as 'recurseElement(Object,StringBuilder)'.

Total number of violations for this class: 3

org.crosswire.jsword.book.filter.thml.SyncTag

Prio	Begin Line	Method	Description
3	80	processTag	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	109	processTag	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	138	processTag	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 3

org.crosswire.jsword.book.install.sword.FTPExample

Prio	Begin Line	Method	Description
3	40	copyDirectory	Prefer StringBuffer over += for concatenating strings
3	128	main	Avoid printStackTrace(); use a logger call instead.
3	138	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 3

org.crosswire.jsword.book.sword.ConfigEntryTable

Prio	Begin Line	Method	Description
3	63	ConfigEntryTable	Avoid unused constructor parameters such as 'isRootConfig'.
3	76	toConf	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	77	toConf	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 3

org.crosswire.jsword.examples.APIExamples

Prio	Begin Line	Method	Description
3	376	installBook	Avoid printStackTrace(); use a logger call instead.
3	409	installBook	Avoid printStackTrace(); use a logger call instead.
3	416	installBook	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 3

org.crosswire.jsword.passage.PassageKeyFactory

Prio	Begin Line	Method	Description
3	450	binarySize	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	484	toBinary	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	530	fromBinary	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.

Total number of violations for this class: 3

org.crosswire.jsword.versification.VersificationToKJVMapper

Prio	Begin Line	Method	Description
3	396		Avoid unused private methods such as 'getNonEmptyMappings(Map,T)'.
3	518	getQualifiedKeys	Avoid unused private methods such as 'getQualifiedKeys(Key)'.
3	532	map	Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()

Total number of violations for this class: 3

org.crosswire.common.diff.DiffCleanup

Prio	Begin Line	Method	Description
3	101	cleanupSemantic	Avoid empty while statements
3	224	cleanupEfficiency	Avoid empty while statements

Total number of violations for this class: 2

org.crosswire.common.progress.Job

Prio	Begin Line	Method	Description
3	362	fireStateChanged	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	389	updateProgress	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.

Total number of violations for this class: 2

org.crosswire.common.util.IOUtil

Prio	Begin Line	Method	Description
3	96	unpackZip	When doing a String.toLowerCase()/toUpperCase() call, use a Locale
3	118	unpackZip	These nested if statements could be combined

Total number of violations for this class: 2

org.crosswire.common.util.IniSection

Prio	Begin Line	Method	Description
3	302	remove	These nested if statements could be combined
3	732		StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).

Total number of violations for this class: 2

org.crosswire.common.util.Languages

Prio	Begin Line	Method	Description
3	66	getName	Avoid empty catch blocks
3	210		Avoid protected fields in a final class. Change to private or package access.

Total number of violations for this class: 2

org.crosswire.common.util.NetUtil

Prio	Begin Line	Method	Description
3	143	makeDirectory	These nested if statements could be combined
3	304	getAsFile	Do not add empty strings

Total number of violations for this class: 2

org.crosswire.common.util.Reporter

Prio	Begin Line	Method	Description
3	167	fireCapture	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3	168	fireCapture	Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()

Total number of violations for this class: 2

org.crosswire.jsword.book.basic.AbstractBookMetaData

Prio	Begin Line	Method	Description
3	266	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	267	toString	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 2

org.crosswire.jsword.book.basic.AbstractPassageBook

Prio	Begin Line	Method	Description
1	235	getBibleBooks	Double checked locking is not thread safe in Java.
2	336		Use of modifier volatile is not recommended.

Total number of violations for this class: 2

org.crosswire.jsword.book.filter.gbf.GBFFilter

Prio	Begin Line	Method	Description
3	67	clone	clone() method should be implemented only if implementing Cloneable interface
3	146	parseTags	Use opposite operator instead of the logic complement operator.

Total number of violations for this class: 2

org.crosswire.jsword.book.filter.osis.OSISFilter

Prio	Begin Line	Method	Description
3	90	toOSIS	Prefer StringBuffer over += for concatenating strings
3	147	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 2

org.crosswire.jsword.book.study.StrongsNumber

Prio	Begin Line	Method	Description
3	90	getStrongsNumber	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3	102	getFullStrongsNumber	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.ZLDBackend

Prio	Begin Line	Method	Description
3	190	dumpIdxRaf	Avoid printStackTrace(); use a logger call instead.
3	193	dumpIdxRaf	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.OpenFileStateManager

Prio	Begin Line	Method	Description
2	275		Use of modifier volatile is not recommended.
2	277		Use of modifier volatile is not recommended.

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.ZLDBackendState

Prio	Begin Line	Method	Description
3	143	getLastUncompressed	Returning 'lastUncompressed' may expose an internal array.
3	156	setLastUncompressed	The user-supplied array 'lastUncompressed' is stored directly.

Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.ZVerseBackendState

Prio	Begin Line	Method	Description
3	170	getLastUncompressed	Returning 'lastUncompressed' may expose an internal array.
3	193	setLastUncompressed	The user-supplied array 'lastUncompressed' is stored directly.

Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookIndexer

Prio	Begin Line	Method	Description
3	185	main	Avoid printStackTrace(); use a logger call instead.
3	192	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookLookup

Prio	Begin Line	Method	Description
3	98	main	Avoid printStackTrace(); use a logger call instead.
3	101	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 2

org.crosswire.jsword.index.lucene.IndexMetadata

Prio	Begin Line	Method	Description
3	104	getLatestIndexVersionStr	Consider simply returning the value vs storing it in local variable 'value'
3	153	generateInstalledBooksIndexVersionReport	Avoid appending characters as strings in StringBuffer.append.

Total number of violations for this class: 2

org.crosswire.jsword.passage.AbstractKeyList

Prio	Begin Line	Method	Description
3	222	clone	clone() method should be implemented only if implementing Cloneable interface
3	261		StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).

Total number of violations for this class: 2

org.crosswire.jsword.passage.TreeKey

Prio	Begin Line	Method	Description
3	155	equals	Ensure you override both equals() and hashCode()
3	189	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 2

org.crosswire.jsword.versification.VersificationsMapper

Prio	Begin Line	Method	Description
1	76	instance	Double checked locking is not thread safe in Java.
2	253		Use of modifier volatile is not recommended.

Total number of violations for this class: 2

gnu.gpl.GPLMsg

Prio	Begin Line	Method	Description
3	30		All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.

Total number of violations for this class: 1

gnu.lgpl.LGPLMsg

Prio	Begin Line	Method	Description
3	30		All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.

Total number of violations for this class: 1

org.crosswire.common.progress.JobManager

Prio	Begin Line	Method	Description
3	144	fireWorkProgressed	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.

Total number of violations for this class: 1

org.crosswire.common.util.CWClassLoader

Prio	Begin Line	Method	Description
3	170	adjustPackageSearch	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 1

org.crosswire.common.util.ClassUtil

Prio	Begin Line	Method	Description
3	108	findClasspathEntry	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 1

org.crosswire.common.util.Ini

Prio	Begin Line	Method	Description
3	249	remove	These nested if statements could be combined

Total number of violations for this class: 1

org.crosswire.common.xml.SerializingContentHandler

Prio	Begin Line	Method	Description
3	175		StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).

Total number of violations for this class: 1

org.crosswire.common.xml.TransformingSAXEventProvider

Prio	Begin Line	Method	Description
3	83	getTemplateInfo	These nested if statements could be combined

Total number of violations for this class: 1

org.crosswire.jsword.JSMsg

Prio	Begin Line	Method	Description
3	30		All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.

Total number of violations for this class: 1

org.crosswire.jsword.JSOtherMsg

Prio	Begin Line	Method	Description
3	30		All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.

Total number of violations for this class: 1

org.crosswire.jsword.book.Bookmark

Prio	Begin Line	Method	Description
3	97	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.DataPolice

Prio	Begin Line	Method	Description
3	66	report	StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.

Total number of violations for this class: 1

org.crosswire.jsword.book.basic.DefaultBookmark

Prio	Begin Line	Method	Description
3	98	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.SourceFilterFactory

Prio	Begin Line	Method	Description
2	92		Use of modifier volatile is not recommended.

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.gbf.GBFTagBuilders

Prio	Begin Line	Method	Description
3	78	getTag	This call to String.startsWith can be rewritten using String.charAt(0)

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.plaintext.PlainTextFilter

Prio	Begin Line	Method	Description
3	64	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.filter.thml.THMLFilter

Prio	Begin Line	Method	Description
3	92	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.install.InstallManager

Prio	Begin Line	Method	Description
3	303	fireInstallersChanged	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.

Total number of violations for this class: 1

org.crosswire.jsword.book.readings.ReadingsBookDriver

Prio	Begin Line	Method	Description
3	61	getBooks	Returning 'books' may expose an internal array.

Total number of violations for this class: 1

org.crosswire.jsword.book.readings.ReadingsKey

Prio	Begin Line	Method	Description
3	103	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.AbstractKeyBackend

Prio	Begin Line	Method	Description
3	151	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.RawBackend

Prio	Begin Line	Method	Description
3	250	getIndex	A switch statement does not contain a break

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.RawFileBackend

Prio	Begin Line	Method	Description
3	164	createDataTextFile	Prefer StringBuffer over += for concatenating strings

Total number of violations for this class: 1

org.crosswire.jsword.book.sword.SwordBook

Prio	Begin Line	Method	Description
3	187	addOSIS	Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()

Total number of violations for this class: 1

org.crosswire.jsword.bridge.BookExporter

Prio	Begin Line	Method	Description
3	95	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 1

org.crosswire.jsword.bridge.ConfParser

Prio	Begin Line	Method	Description
3	76	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 1

org.crosswire.jsword.bridge.DwrBridge

Prio	Begin Line	Method	Description
3	131	getOSISString	Avoid empty catch blocks

Total number of violations for this class: 1

org.crosswire.jsword.examples.BibleToOsis

Prio	Begin Line	Method	Description
3	69	main	Avoid printStackTrace(); use a logger call instead.

Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.InstalledIndex

Prio	Begin Line	Method	Description
3	109	storeInstalledIndexMetadata	Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.

Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.LuceneIndex

Prio	Begin Line	Method	Description
3	216	LuceneIndex	These nested if statements could be combined

Total number of violations for this class: 1

org.crosswire.jsword.passage.AbstractPassage

Prio	Begin Line	Method	Description
3	136	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.BitwisePassage

Prio	Begin Line	Method	Description
3	113	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.DefaultLeafKeyList

Prio	Begin Line	Method	Description
3	244	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.DistinctPassage

Prio	Begin Line	Method	Description
3	99	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.Key

Prio	Begin Line	Method	Description
3	204	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.PassageTally

Prio	Begin Line	Method	Description
3	185	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.RangedPassage

Prio	Begin Line	Method	Description
3	102	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.ReadOnlyKeyList

Prio	Begin Line	Method	Description
3	215	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.ReadOnlyPassage

Prio	Begin Line	Method	Description
3	387	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.passage.SynchronizedPassage

Prio	Begin Line	Method	Description
3	336	clone	clone() method should be implemented only if implementing Cloneable interface

Total number of violations for this class: 1

org.crosswire.jsword.versification.BibleNames

Prio	Begin Line	Method	Description
3	494		Possible unsafe assignment to a non-final static field in a constructor.

Total number of violations for this class: 1

Generated by PMD 5.1.3 on 2016-03-25 - 07:32:10.